src,lib: handle invalid stdio configuration gracefully #55942
+46
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where malformed or unexpected stdio configurations could cause crashes or undefined behavior during child process spawning. This patch ensures robust validation of stdio entries: Fixes: nodejs#55932 Signed-off-by: Juan José Arboleda <[email protected]>
nodejs-github-bot
added
c++
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55942 +/- ##
==========================================
- Coverage 88.49% 88.00% -0.50%
==========================================
Files 653 653
Lines 187728 187741 +13
Branches 36182 35875 -307
==========================================
- Hits 166136 165221 -915
- Misses 14814 15700 +886
- Partials 6778 6820 +42
|
jasnell
reviewed
Nov 23, 2024
| return; | ||
| } | ||
|
|
||
| // Refs: https://github.com/nodejs/node/issues/55932 |
There was a problem hiding this comment.
In addition to the link, a short description of the issue being tested would be helpful so folks don't have to actually follow the link to see what this is about.
jasnell
approved these changes
Nov 23, 2024
|
I'm fine with improving robustness wrt userland prototype changes, but I don't think we should add tests for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where malformed or unexpected stdio configurations could cause crashes or undefined behavior during child process spawning. This patch ensures robust validation of stdio entries:
Fixes: #55932
I don't think we should patch user-space misconfiguration. This is a rare case and, could be extrapolated to different issues. I never faced an issue due to proto mutation. But I personally don't think we should patch that (except for the native layer.)