build: rewrite makefile in python #52788
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a Python build file to replace the Node.js Makefile. In my opinion, maintaining both
vcbuild
andMakefile
(and keeping them feature-compatible) seems difficult. This change should, in my opinion, make maintenance easier, but there may be a learning curve.The Python version assumes that the user, even on Windows, has Make installed. However, it doesn't rely on Unix commands except in the
v8
target (which I aim to change soon) and MacOS-specific cases.