Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: crypto-rsa-dsa testing for dynamic openssl #52781

Closed
wants to merge 2 commits into from
Closed

test: crypto-rsa-dsa testing for dynamic openssl #52781

wants to merge 2 commits into from

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented May 1, 2024

Fixes: #52537

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 1, 2024
lpinca
lpinca approved these changes May 1, 2024
View reviewed changes
test/parallel/test-crypto-rsa-dsa.js Outdated Show resolved Hide resolved
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58842/

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024

Failed to start CI
   ⚠  Something was pushed to the Pull Request branch since the last approving review.
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/8915348709

@github-actions github-actions bot added the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label May 1, 2024
@mhdawson mhdawson removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label May 1, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58848/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58866/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58903/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58905/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58987/

mhdawson added a commit that referenced this pull request May 6, 2024
@mhdawson
test: crypto-rsa-dsa testing for dynamic openssl
b6d162e 
Fixes: #52537

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #52781
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mhdawson
Copy link
Member Author

mhdawson commented May 6, 2024

Landed in b6d162e

@mhdawson mhdawson closed this May 6, 2024
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this pull request May 8, 2024
@mhdawson @Ch3nYuY
test: crypto-rsa-dsa testing for dynamic openssl
8327822 
Fixes: nodejs#52537

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#52781
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 8, 2024
@mhdawson @targos
test: crypto-rsa-dsa testing for dynamic openssl
30a35ae 
Fixes: #52537

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #52781
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parallel.test-crypto-rsa-dsa fails with Missing expected exception
4 participants
@mhdawson @nodejs-github-bot @jasnell @lpinca