[v20.x backport] streams: fixes for webstreams #52773
Open
+249
−280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
MattiasBuelens
force-pushed
the
backport-51168-to-v20.x
branch
2 times, most recently
from
43c8f92
to
a7758ee
Compare
|
can you fix the conflicts? I'll try to backport it in the next v20 release |
PR-URL: nodejs#51168 Reviewed-By: Matteo Collina <[email protected]>
MattiasBuelens
force-pushed
the
backport-51168-to-v20.x
branch
from
a7758ee
to
c6f0199
Compare
|
@marco-ippolito Updated and ready for review. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #51168 to v20.x.
Depends on #52772, so keeping this in draft until that one lands.
This one was a bit tricky, since there are changes to transferables on v22.x that are not on v20.x (such as #50107) which also affect web streams. However, I think I made it work. 🤞