Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage reporter shallow error doc #52746

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

EliphazBouye
Copy link

@EliphazBouye EliphazBouye commented Apr 29, 2024

Add more information in the API test part doc about shallow error from coverage reporter #52670

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@@ -508,6 +508,9 @@ used as an in depth coverage report.
node --test --experimental-test-coverage --test-reporter=lcov --test-reporter-destination=lcov.info
```

* No test results are reported by this reporter.
* This reporter should ideally be used in conjunction with another reporter.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* This reporter should ideally be used in conjunction with another reporter.
* This reporter should ideally be used alongside another reporter.

"in conjunction" is probably harder to understand for ESL folk

Copy link
Member

@atlowChemi atlowChemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, please rebase and edit the commit message of first commit to adhere to guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. test_runner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--test & --test-reporter & --test-reporter-destination will swallow error
6 participants