src: add new underlying async context tracking #52741
Draft
+256
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
force-pushed
the
asynccontext-refactor
branch
5 times, most recently
from
278ba29
to
add0970
Compare
Implements the core underlying bits of a refactored AsyncLocalStorage implementation based on the same mechanism that will be used for the standard AsyncContext API. The implementation is based on the new continuation preserved embedder data API in v8 and is designed to be significantly faster and more efficient that the current promise-hook based implementation. This intentionally only adds the basic pieces, with the intent of spreading the refactored implementation across multiple PRs just to make things easier to review.
jasnell
force-pushed
the
asynccontext-refactor
branch
from
add0970
to
8044767
Compare
|
Is this somewhat related to #48528? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the core underlying bits of a refactored AsyncLocalStorage implementation based on the same mechanism that will be used for the standard AsyncContext API. The implementation is based on the new continuation preserved embedder data API in v8 and is designed to be significantly faster and more efficient that the current promise-hook based implementation.
This intentionally only adds the basic pieces, with the intent of spreading the refactored implementation across multiple PRs just to make things easier to review.
This is still a work in progress.
/cc @bmeck