Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update undici to 6.15.0 #52728

Closed
wants to merge 3 commits into from
Closed

deps: update undici to 6.15.0 #52728

wants to merge 3 commits into from

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Apr 28, 2024 •
edited

This is an automated update of undici to 6.15.0.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Apr 28, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 28, 2024
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2024
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/58774/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/58787/

@nodejs-github-bot nodejs-github-bot changed the title deps: update undici to 6.14.1 deps: update undici to 6.15.0 Apr 29, 2024
mcollina
mcollina approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2024
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/58794/

UlisesGascon
UlisesGascon approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcollina
Copy link
Member

@KhafraDev unfortunately there is a failure related to MessageEvent

https://ci.nodejs.org/job/node-test-commit-arm/52246/
https://ci.nodejs.org/job/node-test-commit-linuxone/43359/nodes=rhel8-s390x/testReport/junit/(root)/parallel/test_worker_message_event/

@KhafraDev
Copy link
Member

I opened #52763

@KhafraDev KhafraDev closed this Apr 30, 2024
@aduh95 aduh95 deleted the actions/tools-update-undici branch May 1, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@benjamingr benjamingr benjamingr approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nodejs-github-bot @mcollina @KhafraDev @benjamingr @UlisesGascon @RafaelGSS @marco-ippolito