src: add missing to_ascii method in dns queries

PR-URL: #48354 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
nodejs · Aug 29, 2023 · afb9cb9 · afb9cb9
1 parent 659c344
commit afb9cb9
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/cares_wrap.cc b/src/cares_wrap.cc
@@ -1413,9 +1413,11 @@ static void Query(const FunctionCallbackInfo<Value>& args) {
  Local<String> string = args[1].As<String>();
  auto wrap = std::make_unique<Wrap>(channel, req_wrap_obj);
 
- node::Utf8Value name(env->isolate(), string);
+ node::Utf8Value utf8name(env->isolate(), string);
+ auto plain_name = utf8name.ToStringView();
+ std::string name = ada::idna::to_ascii(plain_name);
  channel->ModifyActivityQueryCount(1);
- int err = wrap->Send(*name);
+ int err = wrap->Send(name.c_str());
  if (err) {
  channel->ModifyActivityQueryCount(-1);
  } else {