lib: add gyp.js support #1092

indutny · 2017-01-20T03:38:34Z

Added initial gyp.js support with --gypjs command line option.
Environment variable npm_config_gypjs also turns this option on.

Update configure and build usage strings depending on npm_config_gypjs
environment variable.

Set npm_config_gypjs env variable if --gypjs command-line option
was set to affect usage text for configure and build commands.

Update usage strings if --gypjs command-line option was supplied

Trying to load gyp.js module only if --gypjs command-line option was supplied.

cc @bnoordhuis

See #962

See: nodejs#960 Added initial `gyp.js` support with --gypjs command line option. Environment variable `npm_config_gypjs` also turns this option on. Update configure and build usage strings depending on `npm_config_gypjs` environment variable. Set `npm_config_gypjs` env variable if `--gypjs` command-line option was set to affect usage text for `configure` and `build` commands. Update usage strings if `--gypjs` command-line option was supplied Trying to load gyp.js module only if --gypjs command-line option was supplied.

indutny · 2017-01-20T03:38:52Z

cc @pmed

pmed · 2017-01-20T10:46:30Z

Hi Fedor @indutny

I glad to see that gyp.js feature is again moving forward 👍

Is it a rebased version of #962? If so, please note that PR is based on #964, and those two PRs probably should be closed after merging of this one.

README.md

lib/build.js

Fishrock123 · 2017-01-24T21:46:14Z

Why does this require Ninja but default builds don't?

indutny · 2017-01-24T21:55:26Z

@Fishrock123 it doesn't, default slow version of ninja is included. If it wouldn't be ninja, we'd have to use MSVS on Windows and make on Unixes, meaning that gyp.js will have to support two platform-specific generators instead of one cross-platform generator.

indutny · 2017-01-24T21:55:38Z

@bnoordhuis PTAL

Fishrock123 · 2017-01-30T22:15:54Z

@indutny Oh, I was wondering why gyp.js required it when regular gyp didn't? Just maintenance cost of that?

indutny · 2017-01-30T22:21:03Z

@Fishrock123 yep, maintenance cost and a single solution for all platforms.

lin7sh · 2017-02-07T21:05:39Z

any update?

jskorepa · 2017-04-23T16:12:40Z

What is status of this?

refack · 2017-06-08T14:39:08Z

README.md

+$ node-gyp configure --gypjs
+```
+
+It is also possible to set `npm_config_gypjs` environment variable to turn on


IMHO no need for this after #1185

refack · 2017-06-08T14:39:39Z

lib/build.js

  , exec = require('child_process').exec
  , processRelease = require('./process-release')
  , win = process.platform == 'win32'

-exports.usage = 'Invokes `' + (win ? 'msbuild' : 'make') + '` and builds the module'
+exports.usage = 'Invokes `' + (process.env.npm_config_gypjs ? 'ninja' :


Can move to ` templates

refack · 2017-06-08T14:41:10Z

lib/configure.js


-exports.usage = 'Generates ' + (win ? 'MSVC project files' : 'a Makefile') + ' for the current module'
+exports.usage = 'Generates ' + (process.env.npm_config_gypjs ? 'ninja build files' :


refack · 2017-06-08T14:43:15Z

@indutny You up for this? I'd be happy to help/take over...

indutny · 2017-06-08T19:45:31Z

@refack feel free to take over.

refack · 2017-06-08T20:13:02Z

@indutny Ack

Croydon · 2017-07-26T02:40:14Z

Any progress so far?

bnoordhuis · 2017-11-02T11:19:23Z

I've been thinking about this for some time and I've come to the conclusion that I'd rather not have node-gyp be in the business of generating platform- and tooling-specific build files.

That's what gyp.js does, it writes ninja files tailored for the platform and the compiler. As the upstream GYP project has demonstrated, keeping up with platforms and toolchains is a never-ending slog. It takes a lot of time and energy that is better spent elsewhere.

I'm hoping we can leverage an existing tool. My personal preference is cmake; it's stable and just works. Now to write a tool that translates GYP files to CMakeLists...

@indutny WDYT? Reasonable, unreasonable?

LinusU · 2017-11-02T12:10:19Z

I've been using CMake.js for at least one project, and it works amazingly good! It only requires the cmake binary instead of relying on python which is a huge plus, I also prefer writing cmake files to gyp file to be honest...

https://github.com/cmake-js/cmake-js#why-cmake

jbergstroem · 2017-11-02T18:38:13Z

I like gyp.js because of the vision being self-hosted with installing node.js. I'm totally fine if node.js itself uses something else; but a big community win would be having gyp.js Good Enough to build a majority of the node-gyp projects.

indutny · 2017-11-02T19:32:06Z

@bnoordhuis I'm fine with compiling GYP files to CMake in addons, but I have no idea if this is possible in general.

IMO, gyp.js + ninja.js is more viable and as @jbergstroem said is self-hosted.

aduh95 · 2018-04-17T10:09:54Z

With Node.js v4 reaching End Of Life in two weeks, gyp.js will be compatible with all supported Node versions! Maybe we could consider getting rid of the Python dependency. What is the status of this? Is there something I can do to help?

bnoordhuis · 2018-04-17T10:27:02Z

I wouldn't mind revisiting this if @indutny is up to it.

AlJohri · 2018-11-20T21:01:25Z

@indutny any chance we could revive this PR?

indutny · 2018-11-21T21:01:59Z

Of course. Anyone wants to pick it up from me? I haven't touched this code in months now.

rvagg · 2019-06-22T01:10:21Z

I was thinking of picking this up again but only just realised that gyp.js requires ninja. I'm really not a fan of ninja simply because it's not commonly available. We're replacing a python dependency with a ninja dependency, that's arguably asking for more trouble because at least python is easy to fetch and install on every platform. We're going to have to get into the business of shipping ninja binaries like Chromium does.
Maybe getting it beyond ninja is a reasonable task, but that's not a trivial amount of work.

indutny · 2019-06-22T01:19:13Z

There is ninja.js FWIW.

rvagg · 2019-06-22T01:21:10Z

@indutny how mature is that? If I ship a node-gyp with --gypjs support, what's your rough % guess for how much of the current ecosystem is going to be able to successfully build without requiring additional tools (python, ninja, just make and c++)? I'm wondering how much investment I'm going to have to make if I take this on.

indutny · 2019-06-22T01:23:22Z

This is a very good question. Most addons have very simple (if not identical) configuration. gyp.js should handle it well out of box.

The only limiting factor is "python" support: https://github.com/indutny/gyp.js#reduced-python . gyp.js emulates some trivial python commands, but of course cannot do full python support.

rvagg · 2019-06-22T02:09:07Z

Since we're the only remaining major user of GYP I suspect we'll be able to move the ecosystem to not depend on sophisticated python syntax in their gyp files. Maybe we could even move it to support some JavaScript if people really need advanced stuff in there.

jbergstroem reviewed Jan 20, 2017

View reviewed changes

README.md Show resolved Hide resolved

lib/build.js Show resolved Hide resolved

indutny mentioned this pull request Jan 21, 2017

Initial gyp.js support #962

Closed

bnoordhuis mentioned this pull request Feb 7, 2017

python.EXE is v3.5.2, which is not supported by gyp #1042

Closed

gibfahn mentioned this pull request Feb 23, 2017

Python executable "python" is v3.4.3, which is not supported by gyp #746

Closed

refack mentioned this pull request Apr 9, 2017

Replace gyp, node-gyp for addons by adding compiler abstraction nodejs/node#7440

Closed

4 tasks

refack suggested changes Jun 8, 2017

View reviewed changes

refack mentioned this pull request Jun 8, 2017

Consider gyp.js? #960

Closed

refack self-assigned this Jun 8, 2017

refack added build User Friendly labels Jun 8, 2017

cjbj mentioned this pull request Dec 13, 2017

Do you guys support python 3 versions? oracle/node-oracledb#806

Closed

richardlau mentioned this pull request Mar 25, 2018

How to run with gyp.js instead of python? #1398

Closed

maclover7 mentioned this pull request Jul 10, 2018

Implement node-gyp in pure javascript. #634

Closed

9034725985 mentioned this pull request Aug 3, 2018

Use current software to build and run a full node handshake-org/hsd#27

Closed

richardlau mentioned this pull request Sep 28, 2018

Switch to a JS implementation? #1556

Closed

refack mentioned this pull request Nov 11, 2018

Support for Python 3 nodejs/node#21821

Closed

rvagg force-pushed the master branch from 1456ef2 to 7a71d68 Compare April 24, 2019 00:37

rvagg force-pushed the master branch from ed3ff7e to 611bc3c Compare June 21, 2019 02:25

rvagg force-pushed the master branch from bacf53d to 4ef83ed Compare July 22, 2019 03:16

richardlau mentioned this pull request Jun 14, 2023

DISCUSSION: Release handling #2860

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib: add gyp.js support #1092

lib: add gyp.js support #1092

indutny commented Jan 20, 2017

indutny commented Jan 20, 2017

pmed commented Jan 20, 2017

Fishrock123 commented Jan 24, 2017

indutny commented Jan 24, 2017

indutny commented Jan 24, 2017

Fishrock123 commented Jan 30, 2017

indutny commented Jan 30, 2017

lin7sh commented Feb 7, 2017

jskorepa commented Apr 23, 2017

refack Jun 8, 2017

refack Jun 8, 2017

refack Jun 8, 2017

refack commented Jun 8, 2017

indutny commented Jun 8, 2017

refack commented Jun 8, 2017

Croydon commented Jul 26, 2017

bnoordhuis commented Nov 2, 2017

LinusU commented Nov 2, 2017

jbergstroem commented Nov 2, 2017

indutny commented Nov 2, 2017

aduh95 commented Apr 17, 2018

bnoordhuis commented Apr 17, 2018

AlJohri commented Nov 20, 2018

indutny commented Nov 21, 2018

rvagg commented Jun 22, 2019

indutny commented Jun 22, 2019

rvagg commented Jun 22, 2019

indutny commented Jun 22, 2019

rvagg commented Jun 22, 2019


		exports.usage = 'Generates ' + (win ? 'MSVC project files' : 'a Makefile') + ' for the current module'
		exports.usage = 'Generates ' + (process.env.npm_config_gypjs ? 'ninja build files' :

lib: add gyp.js support #1092

Are you sure you want to change the base?

lib: add gyp.js support #1092

Conversation

indutny commented Jan 20, 2017

indutny commented Jan 20, 2017

pmed commented Jan 20, 2017

Fishrock123 commented Jan 24, 2017

indutny commented Jan 24, 2017

indutny commented Jan 24, 2017

Fishrock123 commented Jan 30, 2017

indutny commented Jan 30, 2017

lin7sh commented Feb 7, 2017

jskorepa commented Apr 23, 2017

refack Jun 8, 2017

Choose a reason for hiding this comment

refack Jun 8, 2017

Choose a reason for hiding this comment

refack Jun 8, 2017

Choose a reason for hiding this comment

refack commented Jun 8, 2017

indutny commented Jun 8, 2017

refack commented Jun 8, 2017

Croydon commented Jul 26, 2017

bnoordhuis commented Nov 2, 2017

LinusU commented Nov 2, 2017

jbergstroem commented Nov 2, 2017

indutny commented Nov 2, 2017

aduh95 commented Apr 17, 2018

bnoordhuis commented Apr 17, 2018

AlJohri commented Nov 20, 2018

indutny commented Nov 21, 2018

rvagg commented Jun 22, 2019

indutny commented Jun 22, 2019

rvagg commented Jun 22, 2019

indutny commented Jun 22, 2019

rvagg commented Jun 22, 2019