New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix cache headers for nodejs.org #3437

Open

MattIPv4 wants to merge 1 commit into nodejs:main from MattIPv4:patch-1

Member

MattIPv4 commented Jul 31, 2023

As noted in http://nginx.org/en/docs/http/ngx_http_headers_module.html#add_header, add_header directives are only inherited from parent levels when add_header is not used in the current level.

curl -sI https://node-js-origin/download/release/latest/node-v20.5.0.tar.gz | grep cache-control

curl -sI https://node-js-origin/dist/latest/node-v20.5.0.tar.gz | grep cache-control            
cache-control: public, max-age=3600, s-maxage=14400

There are some blocks that use add_header, so we need to set the cache header again as it will not be inherited otherwise.


chore: fix cache headers for nodejs.org

26b3f49

Member

ovflowd commented Aug 1, 2023

FYI @UlisesGascon @targos if this can be deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment