Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove cache from 404 #3422

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions ansible/www-standalone/resources/config/nodejs.org
Original file line number Diff line number Diff line change
Expand Up @@ -280,11 +280,6 @@ server {
# as set by the @english_fallback location block
# Otherwise, this will fallback to $lang being "en" as defined numerous lines above
location @localized_404 {
# We disable caching of 404 pages as we always want Cloudflare to check if the file now exists
# Some 404s may be caused by the server reaching maximum concurrent file system open() requests
# Disabling cache allows Cloudflare to re-evaluate the same $uri once our server recovers and then properly cache it
add_header Cache-Control "private, no-store, max-age=0" always;

# If this was a rewritten i18n request from @english_fallback, use the localized 404
# If there is no 404 page for that locale, fallback to the English 404
# As a last resort, fallback to NGINX's default 404. This should never happen, and will emit a [crit]
Expand Down