Migrate the cloudantplus node into this module #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hammoaj
approved these changes
Nov 16, 2020
Stwissel
reviewed
Jun 21, 2021
| else if (node.search === "_idx_") { | ||
| console.log(options); | ||
| options.query = options.query || options.q || formatSearchQuery(msg.payload); | ||
| options.include_docs = options.include_docs || true; |
There was a problem hiding this comment.
This one will always return true. [something falsy] || true -> true
undefined || true => true
null || true => true
false || true => true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in this issue: node-red-contrib-ibm-cloud/community#1
This merges the cloudantplus node into this module, keeping the original node types for backwards compatibility.
I've also tidied up some old bluemix references in the readme.