Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pause/resume handling to part passed to onPart. #388

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add pause/resume handling to part passed to onPart. #388

wants to merge 3 commits into from

Conversation

uformia
Copy link

@uformia uformia commented Aug 9, 2016

Add pause/resume handling to part passed to onPart. Prevents buffering if part is pipe'd.

Use case is when onPart is overridden, and the part is being pipe'd to a slow stream (e.g. remote server), and incoming data is sent faster than outgoing link can handle.

@felixge
Copy link
Collaborator

felixge commented Jan 11, 2017

See #412

@kornelski
Copy link
Contributor

Can you add a test for it?

@uformia
Merge pull request #1 from felixge/master
cfcc465 
Getting updates from upstream.
@uformia
Merge pull request #2 from uformia/master
02f11bb 
Pull updates from master
@tunnckoCore tunnckoCore added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Awaiting Response Waiting author or someone to respond to question or clarification Status: Blocked Another issue needs to be resolved first or an external blocker. Type: Enhancement Most issues will probably be for additions or changes. Expected that this will result in a PR. Area: streams Things related to handling streams, and bugs around them. and removed needs test labels Apr 2, 2022
@tunnckoCore tunnckoCore mentioned this pull request Apr 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: streams Things related to handling streams, and bugs around them. Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Awaiting Response Waiting author or someone to respond to question or clarification Status: Blocked Another issue needs to be resolved first or an external blocker. Type: Enhancement Most issues will probably be for additions or changes. Expected that this will result in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uformia @felixge @kornelski @tunnckoCore