New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-fm): make rules configurable #4118
Open
mytharcher
wants to merge
27
commits into
main
Choose a base branch
from
T-251
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,292
−1,366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been linked to 1 task:
|
chenos
requested changes
May 6, 2024
packages/core/client/src/schema-component/antd/association-field/FileManager.tsx
Outdated
Show resolved
Hide resolved
packages/core/client/src/schema-component/antd/association-field/FileManager.tsx
Outdated
Show resolved
Hide resolved
packages/core/client/src/schema-component/antd/upload/type.d.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Tests results for "E2E"9 flaky977 passed, 28 skipped Full HTML report. Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make rules for uploading files configurable.
Motivation
For better hint user the file size limit, and not allow to do upload action when rules validation failed.
Key changes
Upload
component.storages:getRule
action.Test plan
Suggestions
Through cases.
Underlying risk
Anywhere using
Upload.Attachment
andUpload.DraggerV2
.Showcase