Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-fm): make rules configurable #4118

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

feat(plugin-fm): make rules configurable #4118

wants to merge 27 commits into from

Conversation

mytharcher
Copy link
Contributor

Description

Make rules for uploading files configurable.

Motivation

For better hint user the file size limit, and not allow to do upload action when rules validation failed.

Key changes

  • Frontend
    • Refactored Upload component.
  • Backend
    • Add storages:getRule action.

Test plan

Suggestions

Through cases.

Underlying risk

Anywhere using Upload.Attachment and Upload.DraggerV2.

Showcase

image

image

Copy link

height bot commented Apr 20, 2024

This pull request has been linked to 1 task:

💡Tip: Add "Close T-251" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

Tests results for "E2E"

9 flaky ⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › TableActionInitializers & GanttActionInitializers & MapActionInitializers should add bulk edit action › bulk edit in TableActionInitializers
⚠️ [chromium] › plugins/@nocobase/plugin-action-custom-request/src/client/__e2e__/schemaSettings.test.ts:13:7 › custom request action › edit button
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-update/src/client/__e2e__/schemaSettings.test.ts:14:7 › data will be updated && Assign field values && after successful submission › data will be updated && Assign field values && after successful submission
⚠️ [chromium] › plugins/@nocobase/plugin-auth/src/client/__e2e__/auth.test.ts:21:7 › auth › register
⚠️ [chromium] › plugins/@nocobase/plugin-file-manager/src/client/__e2e__/block.test.ts:53:7 › file collection block › correctly size
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/form/__e2e__/form-create/dragAndDrop.test.ts:12:5 › fields
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/association.test.ts:245:5 › association block action permission
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/configure.test.ts:13:5 › allows to configure interface
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaSettings.test.ts:14:7 › bulk edit action setting › data will be updated && edit form configure

977 passed, 28 skipped
✔️✔️✔️

Full HTML report. Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants