fix: mapValues should not update the object in place

[pranaygp]

The original lodash implementation of mapValues is a pure function that doesn't modify the object in place.

The new implementation is causing issues in test cases where the same object is used for the nock response and for validation.

Here's an example of a test that broke when attempting to use the beta

  describe('#patch', () => {
    it('can patch data locally', async () => {
      const patchBody = {name: 'test', id: 1234};

      nock(baseUrl)
        .patch('/', patchBody)
        .reply(200, patchBody);

	  // client#patch uses URL encoding
      const response = await client.patch('/', patchBody);
      should(response.body).eql(patchBody); // breaks
      should(response.statusCode).eql(200);

      should(nock.isDone()).eql(true);
    });
  });

[pranaygp]

cc @mikicho - Not sure if you're the best person to assign for review on this :)

[mikicho]

@pranaygp Thanks for opening this PR!

What's client in your example? axios? http.get?

[pranaygp]

It's a custom wrapper around needle

for PATCH requests, we send the data as formdata instead of JSON. That's the triggered the codepath leading to this mapValues implementation

[mikicho]

LGTM. Thanks for your contribution!

[github-actions]

🎉 This PR is included in version 14.0.0-beta.6 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀