Refactor align converter #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change reflect.DeepEqual to slices.Equal. rightAlign is changed to not reset every time. Change trimLeft and trimRight to trimmedIndices. markNext and markPrev are renamed to nextMark and prevMark.
ccoVeille
reviewed
Sep 8, 2024
Comment on lines
+365
to
+371
| esConv string = "es" // esConv processes escape sequence(default). | ||
| rawConv string = "raw" // rawConv is displayed without processing escape sequences as they are. | ||
| alignConv string = "align" // alignConv is aligned in each column. | ||
| ) | ||
|
|
||
| const ( | ||
| generalName string = "general" |
There was a problem hiding this comment.
Usually constants are sharing a common prefix, allowing to find the easily when using completion in the IDE, they are also ordered in the godoc if they are exported
Suggested change
| esConv string = "es" // esConv processes escape sequence(default). | |
| rawConv string = "raw" // rawConv is displayed without processing escape sequences as they are. | |
| alignConv string = "align" // alignConv is aligned in each column. | |
| ) | |
| const ( | |
| generalName string = "general" | |
| convEscaped string = "es" // convEscaped processes escape sequence(default). | |
| convRaw string = "raw" // convRaw is displayed without processing escape sequences as they are. | |
| convAlign string = "align" // convAlign is aligned in each column. | |
| ) | |
| const ( | |
| nameGeneral string = "general" |
There was a problem hiding this comment.
Thank you for your comment.
That's right. Change.
| @@ -120,18 +120,19 @@ func (root *Root) setAlignConverter() { | |||
| maxWidths, addRight = m.maxColumnWidths(maxWidths, addRight, ln) | |||
| } | |||
|
|
|||
| if !reflect.DeepEqual(m.alignConv.maxWidths, maxWidths) { | |||
| if !slices.Equal(m.alignConv.maxWidths, maxWidths) { | |||
There was a problem hiding this comment.
Based of the fact the if starts here and ends with the function, you could do this
Suggested change
| if !slices.Equal(m.alignConv.maxWidths, maxWidths) { | |
| if slices.Equal(m.alignConv.maxWidths, maxWidths) { | |
| return | |
| } |
Comment on lines
-247
to
+248
| // markNext moves to the next mark. | ||
| func (root *Root) markNext(context.Context) { | ||
| // nextMark moves to the next mark. | ||
| func (root *Root) nextMark(context.Context) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
This depends on the naming rules of the function name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change reflect.DeepEqual to slices.Equal.
rightAlign is changed to not reset every time.
Change trimLeft and trimRight to trimmedIndices.
markNext and markPrev are renamed to nextMark and prevMark.