Add afforder strategy cli arg

noahshinn · Dec 6, 2023 · 9a1127a · 9a1127a
1 parent 51d6530
commit 9a1127a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/afforder/strategy.go b/afforder/strategy.go
@@ -2,6 +2,7 @@ package afforder
 
 import (
  "collaborativebrowser/afforder/afforderstrategy"
+ "collaborativebrowser/afforder/afforderstrategy/filterafforder"
  "collaborativebrowser/afforder/afforderstrategy/functionafforder"
  "log"
 )
@@ -10,6 +11,7 @@ type AfforderStrategyID string
 
 const (
  AfforderStrategyIDFunctionAfforder AfforderStrategyID = "function_afforder"
+ AfforderStrategyIDFilterAfforder AfforderStrategyID = "filter_afforder"
 )
 
 const DefaultAfforderStrategyID = AfforderStrategyIDFunctionAfforder
@@ -18,6 +20,8 @@ func AfforderStrategyByID(id AfforderStrategyID) afforderstrategy.AfforderStrate
  switch id {
  case AfforderStrategyIDFunctionAfforder:
  return functionafforder.New()
+ case AfforderStrategyIDFilterAfforder:
+ return filterafforder.New()
  default:
  log.Printf("invalid afforder strategy ID: %s; defaulting to %s", id, DefaultAfforderStrategyID)
  return functionafforder.New()

diff --git a/cmd/shell/shell.go b/cmd/shell/shell.go
@@ -3,6 +3,7 @@ package main
 import (
  "bufio"
  "collaborativebrowser/actor"
+ "collaborativebrowser/afforder"
  "collaborativebrowser/browser"
  "collaborativebrowser/runner/finiterunner"
  "collaborativebrowser/trajectory"
@@ -21,6 +22,7 @@ func main() {
  logPath := flag.String("log-path", "out", "the path to write the trajectory and browser display to")
  initialURL := flag.String("url", "https://www.google.com", "the initial url to visit")
  actorStrategy := flag.String("actor-strategy", "base_llm", "the actor strategy to use; one of [base_llm, reflexion]")
+ afforderStrategy := flag.String("afforder-strategy", "function_afforder", "the afforder strategy to use; one of [function_afforder, filter_afforder]")
  verbose := flag.Bool("verbose", false, "whether to print verbose debug logs")
  flag.Parse()
 
@@ -46,11 +48,15 @@ func main() {
  if *actorStrategy == "" {
  *actorStrategy = string(actor.DefaultActorStrategyID)
  }
+ if *afforderStrategy == "" {
+ *afforderStrategy = string(afforder.DefaultAfforderStrategyID)
+ }
  runner, err := finiterunner.NewFiniteRunnerFromInitialPage(ctx, *initialURL, apiKeys, &finiterunner.Options{
- MaxNumSteps: 5,
- BrowserOptions: browserOptions,
- LogPath: *logPath,
- ActorStrategyID: actor.ActorStrategyID(*actorStrategy),
+ MaxNumSteps: 5,
+ BrowserOptions: browserOptions,
+ LogPath: *logPath,
+ ActorStrategyID: actor.ActorStrategyID(*actorStrategy),
+ AfforderStrategyID: afforder.AfforderStrategyID(*afforderStrategy),
  })
  if err != nil {
  panic(fmt.Errorf("failed to create runner: %w", err))