Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple mod policy #232

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Multiple mod policy #232

wants to merge 14 commits into from

Conversation

anna-abelman
Copy link
Collaborator

Updated run_policy functions and pred_prod_outputs. @Paul-Carvalho would you mind checking a few things before merging?

  1. checking the marginal utility income error is working correctly for both console and gui
  2. if the logit_zonal models are running correctly in the policy function... I get zero difference but no errors
  3. check the code in the welfare supplementary table specifically the mean_total_welfare_loss column

*note - I can clean up the code after you review

Merge branch 'master' of github.com:noaa-nwfsc/FishSET into multiple_mod_policy

# Conflicts:
#	inst/ShinyFiles/MainApp/run_policy_server.R
Merge branch 'master' of github.com:noaa-nwfsc/FishSET into multiple_mod_policy

# Conflicts:
#	inst/ShinyFiles/MainApp/server.R
@Paul-Carvalho
Copy link
Collaborator

@anna-abelman here's a few comments so far, but I haven't gone through everything yet.

  1. The input label for selecting the marginal utility of income just says "Select for [model name]" but doesn't indicate that this input should be the marginal utility of income (the popup info says this but I think marginal utility of income should be in the name).
  2. The error message for marginal utility of income doesn't work for me. I'm able to run the simulation with exp catch and distance (V1) as the marginal utility of income with "Income cost..." = TRUE. Also, when I select FALSE for "Income cost..." the app crashes.
  3. The zonal logit policy function seems to be running ok, but the welfare function isn't working. Nothing is plotted for welfare. You can run the zonal logit in the master branch and compare outputs.
  4. Welfare supplementary table looks good. But again nothing coming up for zonal logit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants