[OpenCL] Fix Half-Precision Kernels #3119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djeong20
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8,
EunjuYang,
dkjung and
haehun
as code owners
SeoHyungjun
approved these changes
Apr 16, 2025
| @@ -26,6 +26,7 @@ namespace nntrainer { | |||
| // get global cl_context to use in kernels | |||
| static ClContext *attention_cc = | |||
| static_cast<ClContext *>(Engine::Global().getRegisteredContext("gpu")); | |||
| static ClBufferManager &clbuffInstance = ClBufferManager::getInstance(); | |||
There was a problem hiding this comment.
Why aren't clbuffInstance.getOutBufferA() and .getOutBufferB() managed as separate variables even though they are used multiple times?
djeong20
force-pushed
the
bugfix/engine/opencl_context_v8
branch
from
65628fd to
1a28224
Compare
djeong20
changed the title
This patch fixes half-precision OpenCL kernels to accumulate values in single-precision format. It also corrects the output for the BLAS kernel unit test. **Self-evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghyeon Jeong <[email protected]>
djeong20
force-pushed
the
bugfix/engine/opencl_context_v8
branch
from
1a28224 to
d3a38c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes half-precision OpenCL kernels to accumulate values in single-precision format. It also corrects the output for the BLAS kernel unit test.
Self-evaluation: