Skip to content

Fix issue #3078, #2993 (throwing error not in ErrorNotification's destructor) @open sesame 04/09 10:28 #3097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix issue #3078, #2993 (throwing error not in ErrorNotification's destructor) @open sesame 04/09 10:28 #3097

wants to merge 1 commit into from

Conversation

dkjung
Copy link
Collaborator

@dkjung dkjung commented Apr 7, 2025 •
edited
Loading

#2993 #3078

  • Empty destructor definition
  • Move destructor's code in &&operator<<
    • &&operator<< throws the designated exception

Self evaluation:

  1. Build test: [*]Passed [ ]Failed [ ]Skipped
  2. Run test: [*]Passed [ ]Failed [ ]Skipped

Fix issue nnstreamer#3078, nnstreamer#2993
85fef49 
- Empty destructor definition
- Move destructor's code in &&operator<<
  - &&operator<< throws the designated exception

Signed-off-by: Daekyoung Jung <[email protected]>
@dkjung dkjung self-assigned this Apr 7, 2025
baek2sm
baek2sm approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@baek2sm baek2sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jijoongmoon jijoongmoon changed the title Fix issue #3078, #2993 (throwing error not in ErrorNotification's destructor) Fix issue #3078, #2993 (throwing error not in ErrorNotification's destructor) @open sesame 04/09 10:28 Apr 9, 2025
@jijoongmoon
Copy link
Collaborator

Could you check the CI Fails?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baek2sm baek2sm baek2sm approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo will be requested when the pull request is marked ready for review myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon will be requested when the pull request is marked ready for review jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you will be requested when the pull request is marked ready for review again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung will be requested when the pull request is marked ready for review jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs will be requested when the pull request is marked ready for review leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong will be requested when the pull request is marked ready for review wooksong is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang will be requested when the pull request is marked ready for review gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 will be requested when the pull request is marked ready for review anyj0527 is a code owner

@lhs8928 lhs8928 Awaiting requested review from lhs8928 lhs8928 will be requested when the pull request is marked ready for review lhs8928 is a code owner

@songgot songgot Awaiting requested review from songgot songgot will be requested when the pull request is marked ready for review songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu will be requested when the pull request is marked ready for review jihochu is a code owner

@DonghakPark DonghakPark Awaiting requested review from DonghakPark DonghakPark will be requested when the pull request is marked ready for review DonghakPark is a code owner

@SeoHyungjun SeoHyungjun Awaiting requested review from SeoHyungjun SeoHyungjun will be requested when the pull request is marked ready for review SeoHyungjun is a code owner

@skykongkong8 skykongkong8 Awaiting requested review from skykongkong8 skykongkong8 will be requested when the pull request is marked ready for review skykongkong8 is a code owner

@djeong20 djeong20 Awaiting requested review from djeong20 djeong20 will be requested when the pull request is marked ready for review djeong20 is a code owner

@EunjuYang EunjuYang Awaiting requested review from EunjuYang EunjuYang will be requested when the pull request is marked ready for review EunjuYang is a code owner

@haehun haehun Awaiting requested review from haehun haehun will be requested when the pull request is marked ready for review haehun is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

@dkjung dkjung

Labels
Need Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkjung @jijoongmoon @baek2sm