Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce length of function but perform same action #56

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

Schiano-NOAA
Copy link
Collaborator

Work in progress - Reducing redundancy in code and make it more efficient

@sbreitbart-NOAA
Copy link
Collaborator

@Schiano-NOAA made a minor change to ensure doc_path was created when appropriate. Otherwise, I like the more efficient structure of this function! Thanks for your effort.

@Schiano-NOAA Schiano-NOAA marked this pull request as ready for review March 6, 2025 20:05
@Schiano-NOAA
Copy link
Collaborator Author

@sbreitbart-NOAA please ignore if you received another review notification -- I switched this off a draft and am merging

@Schiano-NOAA Schiano-NOAA merged commit b3d8f34 into html-plots Mar 6, 2025
3 of 9 checks passed
@sbreitbart-NOAA sbreitbart-NOAA deleted the rework-html-plots branch March 6, 2025 20:07
Schiano-NOAA added a commit that referenced this pull request Mar 6, 2025
* update(html_all_figs_tables.R) minor improvements to reduce redundancy in code

* moved doc_path line to ensure doc_path would be created if question1 = y

---------

Co-authored-by: sbreitbart-NOAA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants