Reduce length of function but perform same action #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Schiano-NOAA made a minor change to ensure doc_path was created when appropriate. Otherwise, I like the more efficient structure of this function! Thanks for your effort. |
|
@sbreitbart-NOAA please ignore if you received another review notification -- I switched this off a draft and am merging |
Schiano-NOAA
added a commit
that referenced
this pull request
Mar 6, 2025
* update(html_all_figs_tables.R) minor improvements to reduce redundancy in code * moved doc_path line to ensure doc_path would be created if question1 = y --------- Co-authored-by: sbreitbart-NOAA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress - Reducing redundancy in code and make it more efficient