change package name to stockplotr #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added units to plots that can produce relative values (biomass, recruitment, and spawning biomass) as per #44 * Added new arg to add_more_key_quants to allow for values to be scaled; updated fxns with this arg (plot_biomass, recruitment, ssb); moved code that computes min/max B, R, ssb from write_captions to add_more_key_quants; updated add_more_key_quants to label scaled values with appropriate label that's inclusive of scale's order of magnitude * Added code that adds new key quantities extracted in add_more_key_quants into captions/alt text csv; updated exp_all_figs_tables to include new arguments specifying scaling amounts for biomass, recruitment, and sp biomass plots * Fix test * Update documentation for exp_all_figs_tables * Attempt to fix test failures by fixing path in add_more_key_quants() * add dat arg to B, R, SSB plotting fxns, and add_more_key_quants, to address failing tests * Updates per Schiano-NOAA's comments on PR (minor edits to code, documentation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing package name