-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render large tables #158
base: dev
Are you sure you want to change the base?
Render large tables #158
Conversation
… to require changing page orientation from portrait to landscape. Alter the Tables qmd to allow orientation changes for each table, if necessary.
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have not tested but looks like in practice it should just check if the table needs to be rotated or not
Next thing to think about is how this could be applied for custom tables? or do we just state a recommended practice to follow? |
Thanks! What I hope is one of the last components of this PR, which I'm working on now, is designing a way to accommodate tables that need landscape orientation but are too wide to be shrunken with the existing workflow (e.g., red snapper, which has a 60" wide indices table without shrinking, and with shrinking, has text that is too small to read). |
Great point. I'll write up an explanation for our workflow and explain how the user can do it manually for custom tables in the FAQs and manual. |
…y splitting into multiple tables
What is the feature?
How have you implemented the solution?
create_tables_doc
, then customizing the appropriate chunk in the 08_tables.qmd file so that tables wider than 5" are placed in a landscape-orientation page, and are forced to shrink in width to 7.5" (this shrinks the text to fit).Does the PR impact any other area of the project, maybe another repo?