Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor features and improvements for next version #150

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Minor features and improvements for next version #150

wants to merge 14 commits into from

Conversation

Schiano-NOAA
Copy link
Collaborator

What is the feature?

  • Developments for release v1.1

How have you implemented the solution?

*Series of PRs

Does the PR impact any other area of the project, maybe another repo?

*Yes - some updates and improvements to the template and workings of the package

Schiano-NOAA and others added 3 commits January 17, 2025 14:16
@Schiano-NOAA @sbreitbart-NOAA
Merge newer dev branch into old (#148)
c813f95 
* Minor grammatical changes just to set up new dev-1.1 branch (changed quarto --> Quarto)

* Feat(vignettes):
-added tables of contents to vignettes
-added tip for how to edit rda files to a11y vignette
-added link to faqs vignette to a11y vignette re: how to edit alt text and captions

---------

Co-authored-by: sbreitbart-NOAA <[email protected]>
@sbreitbart-NOAA
Update accessibility vignette
70b5ba4
@iantaylor-NOAA
fix to incorrect reference in .bib file (#149)
77a802a 
* fix incorrect reference

* add url to reference fix
@github-actions GitHub Actions
Copy link
Contributor

Instructions for code reviewer

Hello reviewer, thanks for taking the time to review this PR!

  • Please use this checklist during your review, checking off items that you have verified are complete!
  • For PRs that don't make changes to code (e.g., changes to README.md or Github actions workflows), feel free to skip over items on the checklist that are not relevant. Remember it is still important to do a thorough review.
  • Then, comment on the pull request with your review indicating where you have questions or changes need to be made before merging.
  • Remember to review every line of code you’ve been asked to review, look at the context, make sure you’re improving code health, and compliment developers on good things that they do.
  • PR reviews are a great way to learn, so feel free to share your tips and tricks. However, for optional changes (i.e., not required for merging), please include nit: (for nitpicking) before making the suggestion. For example, nit: I prefer using a data.frame() instead of a matrix because...
  • Engage with the developer when they respond to comments and check off additional boxes as they become complete so the PR can be merged in when all the tasks are fulfilled. Make it clear when this has been reached by commenting on the PR with something like This PR is now ready to be merged, no changes needed.

Checklist

  • The PR is requested to be merged into the appropriate branch (typically main)
  • The code is well-designed.
  • The functionality is good for the users of the code.
  • Any User Interface changes are sensible and look good.
  • The code isn’t more complex than it needs to be.
  • Code coverage remains high, indicating the new code is tested.
  • The developer used clear names for everything.
  • Comments are clear and useful, and mostly explain why instead of what.
  • Code is appropriately documented (doxygen and roxygen).

Schiano-NOAA and others added 11 commits January 21, 2025 13:47
@Schiano-NOAA
remove static NOAA Fishies in authorship
f2e6b75
@Schiano-NOAA
update NOAA fisheries affiliations
4361f7f
@Schiano-NOAA
remove replicate nmfs palette and add_theme
0e73922
@Schiano-NOAA
remove files
36595f0
@Schiano-NOAA @sbreitbart-NOAA @github-actions
Custom template fixes (#143)
b58e3d6 
* update(create_template): comment out skeleton pop up at the end

* update(add_section): add functionality for putting new subsection into section

* Update(add_section): fix pathing for locating section to place code and change from add_chunk to add_child

* update(create_template): select only custom_sections when user wants to make a different outline of report

custom must = TRUE otherwise copies all files

* Fix(create_template): adjust if statement argument for custom_sections

* Add nmfspalette package back in

* removed add_theme and associated test and documentation

* remove static NOAA Fishies in authorship

* update NOAA fisheries affiliations

Co-authored-by: Schiano-NOAA <[email protected]>

---------

Co-authored-by: sbreitbart-NOAA <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Schiano-NOAA <[email protected]>
@sbreitbart-NOAA
Fix(create_template):
3943d9f 
-Fix so that rda files can be added as input, if already created, OR generated if model results are included as an argument.
-Update documentation
@sbreitbart-NOAA
Merge pull request #151 from nmfs-ost/fix-rda
12cdc34 
Fix(create_template)
@Schiano-NOAA
update(format_quarto): add functionality for html formatting with ass…
07c7348 
…ociated files and changes to create_template (#152)
@sbreitbart-NOAA
small comment update
c994f93
@Schiano-NOAA
update(create_template): custom_sections adds all selected plus refs,…
8ef694f 
… acknow, and tables and figs if desired
@Schiano-NOAA @sbreitbart-NOAA @github-actions
Custom template fixes (#143)
9c95677 
* update(create_template): comment out skeleton pop up at the end

* update(add_section): add functionality for putting new subsection into section

* Update(add_section): fix pathing for locating section to place code and change from add_chunk to add_child

* update(create_template): select only custom_sections when user wants to make a different outline of report

custom must = TRUE otherwise copies all files

* Fix(create_template): adjust if statement argument for custom_sections

* Add nmfspalette package back in

* removed add_theme and associated test and documentation

* remove static NOAA Fishies in authorship

* update NOAA fisheries affiliations

Co-authored-by: Schiano-NOAA <[email protected]>

---------

Co-authored-by: sbreitbart-NOAA <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Schiano-NOAA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Schiano-NOAA @sbreitbart-NOAA @iantaylor-NOAA