Skip to content

flake: add Flake Parts tree into testbed environment #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

trueNAHO
Copy link
Member

@trueNAHO trueNAHO commented Jul 8, 2025

commit 326a51f3501e9d5a96afa72d39db437742f7cd89
Author: NAHO <[email protected]>
Date:   2025-07-08 19:38:21 +0200

    flake: add Flake Parts tree into testbed environment

    Add the Flake Parts tree into the testbed environment, enabling
    realistic testing interactions.

    Flake Parts is chosen over Stylix to reduce cache invalidations, and
    over other flake inputs as the smallest tree.

 stylix/testbed/default.nix             | 1 +
 stylix/testbed/modules/flake-parts.nix | 7 +++++++
 2 files changed, 8 insertions(+)

commit c154a1b51a1a90ae09eebe30068c27bdadfe5b40
Author: NAHO <[email protected]>
Date:   2025-07-08 19:41:02 +0200

    treewide: replace custom testbed test files with Flake Parts tree

 modules/bat/testbeds/bat.nix       | 12 +-----------
 modules/micro/testbeds/micro.nix   |  8 +-------
 modules/neovim/testbeds/neovim.nix | 10 ++--------
 modules/neovim/testbeds/nixvim.nix | 12 +-----------
 modules/neovim/testbeds/nvf.nix    | 12 +-----------
 modules/neovim/testbeds/vim.nix    |  8 +-------
 modules/zed/testbeds/zed.nix       |  8 +-------
 7 files changed, 8 insertions(+), 62 deletions(-)

commit 2dcb2c918e878575d4c87e9236aadd49fccfabb2
Author: NAHO <[email protected]>
Date:   2025-07-11 15:19:21 +0200

    treewide: expand testbed interactions with Flake Parts tree

 modules/emacs/testbeds/emacs.nix                         | 10 ++--------
 modules/gedit/testbeds/gedit.nix                         | 11 ++---------
 modules/gnome-text-editor/testbeds/gnome-text-editor.nix | 11 ++---------
 modules/neovim/testbeds/neovide.nix                      | 10 ++--------
 modules/vscode/testbeds/vscode.nix                       | 13 ++++---------
 5 files changed, 12 insertions(+), 43 deletions(-)

Things done

Notify maintainers

@trueNAHO trueNAHO added the backport: release-25.05 Changes to release-25.05 stable branch label Jul 8, 2025
@stylix-automation stylix-automation bot added the topic: testbed Testbed changes label Jul 8, 2025
@trueNAHO trueNAHO marked this pull request as draft July 8, 2025 18:31
Copy link
Contributor

@awwpotato awwpotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

trueNAHO added 3 commits July 11, 2025 14:58
Add the Flake Parts tree into the testbed environment, enabling
realistic testing interactions.

Flake Parts is chosen over Stylix to reduce cache invalidations, and
over other flake inputs as the smallest tree.
@trueNAHO trueNAHO force-pushed the flake-add-flake-parts-tree-into-testbed-environment branch from 5d08b2b to 2dcb2c9 Compare July 11, 2025 14:03
Copy link
Member Author

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that all touched testbeds can be run in parallel with:

git diff --stat master.. modules |
  head --lines -1 |
  sed --regexp-extended 's/.*\/([^/]+)\.nix.*/\1/' |
  parallel --bar --color --color-failed --tagstring '{}' nix run .#testbed:{}:dark

From my testing, all testbeds behave correctly, except for Emacs, VSCode, and Zed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testbed does not seem to have any color scheme when opening the file:

nix run github:trueNAHO/stylix/flake-add-flake-parts-tree-into-testbed-environment#testbed:emacs:dark

If manual intervention is required, /modules/emacs/meta.nix's description attribute should be added.


CC: @panchoh

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testbed does not seem to have any color scheme when opening the file:

nix run github:trueNAHO/stylix/flake-add-flake-parts-tree-into-testbed-environment#testbed:vscode:dark

Note that it takes a very long time for codium to start...


CC: @Flameopathic @danth

Copy link
Member Author

@trueNAHO trueNAHO Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testbed does not seem to have any color scheme when opening the file:

nix run github:trueNAHO/stylix/flake-add-flake-parts-tree-into-testbed-environment#testbed:zed:dark

Also, the pop-up notification is rather annoying.

@trueNAHO trueNAHO marked this pull request as ready for review July 11, 2025 14:14
@stylix-automation stylix-automation bot added the status: merge conflict Merge conflict label Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: release-25.05 Changes to release-25.05 stable branch status: merge conflict Merge conflict topic: testbed Testbed changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants