feat(cursors): Cursor launch feedback #471
Conversation
This is to assist in implementing declarable launch feedback settings in kde.
Implementation does not match exact behaviours of kde settings app. For example, when selecting the "Bouncing" option for cursor feedback kde will have no settings written to klaunchrc. However this implementation is very explicit and outputs all cursor settings options. Although it differs from kde's implementation, this more explicit version still works.
This is to assist in making the feedback displayed on the icon in the task manager a declerative setting.
HeitorAugustoLN
left a comment
HeitorAugustoLN
left a comment
There was a problem hiding this comment.
Thanks for contributing to plasma-manager! Also please format the code you wrote with nixfmt-rfc-style. I also need to check if the values are working correctly, which I will do later, since I am not using plasma right now, so I will need to set up a vm first, but everything else looks good to me
Now the allowed values are enforced when configuring cursor feedback.
magnouvean
left a comment
magnouvean
left a comment
There was a problem hiding this comment.
Generally this looks good now imo. See my one comment though. After that is cleared I reckon we can merge :)
Sorry for the late review here, I haven't had much time for plasma-manager lately due to other work.
| "None" = { | ||
| BusyCursorSettings.Blinking = "false"; | ||
| BusyCursorSettings.Bouncing = "false"; | ||
| FeedbackStyle.BusyCursor = "false"; | ||
| }; | ||
| "Static" = { | ||
| BusyCursorSettings.Blinking = "false"; | ||
| BusyCursorSettings.Bouncing = "false"; | ||
| FeedbackStyle.BusyCursor = "true"; | ||
| }; | ||
| "Blinking" = { | ||
| BusyCursorSettings.Blinking = "true"; | ||
| BusyCursorSettings.Bouncing = "false"; | ||
| FeedbackStyle.BusyCursor = "true"; | ||
| }; | ||
| "Bouncing" = { | ||
| BusyCursorSettings.Blinking = "false"; | ||
| BusyCursorSettings.Bouncing = "true"; | ||
| FeedbackStyle.BusyCursor = "true"; | ||
| }; |
There was a problem hiding this comment.
Are the quotes really necessary here? I would think maybe for example:
{
None = {
BusyCursorSettings.Blinking = false;
BusyCursorSettings.Bouncing = false;
FeedbackStyle.BusyCursor = false;
};
...
}Would work? If so that should be better. Also maybe grouping on BusyCursorSettings is cleaner, i.e.:
{
None = {
BusyCursorSettings = {
Blinking = false;
Bouncing = false;
};
FeedbackStyle.BusyCursor = false;
};
...
}
|
This would be a great feature! The bouncing cursor looks so tacky! 😄 |
4 participants
While I was configuring my kde setup I noticed that the settings for cursor launch feedback seemed to be missing.
I had a go at adding these settings to the cursorType since they are listed under cursors in kde settings, and added configuration to klaunchrc which I believe is the only place these settings have an effect.
I'm quite new to nix so please let me know if it needs any changes or if you need me to refactor this.