Skip to content

modules/nixpkgs: don't assign elaborated platforms #2968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

MattSturgeon
Copy link
Member

See NixOS/nixpkgs#376988

Cherry-picked from #2964. There's no reason why we can't merge this early, to benefit users who have a nixpkgs revision ahead of ours.

Fixes #2967

@MattSturgeon MattSturgeon requested a review from a team February 5, 2025 00:00
@MattSturgeon

This comment was marked as resolved.

This comment was marked as resolved.

Copy link
Contributor

mergify bot commented Feb 5, 2025

This pull request, with head sha f99264c1fb8e98e0712cdad2744afa8b40661dcc, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha f99264c1fb8e98e0712cdad2744afa8b40661dcc is part of the main branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch nixpkgs_module_fix, this means GitHub will fail to detect the merge.

@mergify mergify bot merged commit f99264c into nix-community:main Feb 5, 2025
4 checks passed
@mergify mergify bot temporarily deployed to github-pages February 5, 2025 15:52 Inactive
@MattSturgeon MattSturgeon deleted the nixpkgs_module_fix branch February 5, 2025 16:41
@MattSturgeon
Copy link
Member Author

MattSturgeon commented Feb 5, 2025

FYI: some parts of this PR will probably end up being reworked or reverted. The upstream change has been reverted for now, until it can be implemented in a less disruptive way. See also: NixOS/nixpkgs#376988 (comment).

The main change of not assigning an elaborated system to nixpkgs.*Platform options is a good change and will remain, regardless of how other parts of this PR are reworked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkgs/top-level assertion failed
3 participants