Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(editor-setup): Mention built-in in LSP mode #598

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(editor-setup): Mention built-in in LSP mode #598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion nixd/docs/editor-setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## We ❤️ Contributions!
## We ❤ Contributions!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this "heart" should be changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heart is changed because there is an unrecognized character on Windows.

I've tried to revert it, but nothing has changed. 🤔 (For some reason, it remains the blue heart instead of the original red heart.)

Please update this doc (tweaks, tricks, or how to setup for another editor)!

Expand Down Expand Up @@ -110,6 +110,11 @@ A simple Emacs Lisp configuration that adds nixd to LSP Mode in the mean time is
:server-id 'nixd)))
```

> [!NOTE]
>
> The client is built-in to lsp-mode after `8.0.0`; you don't need this if you
> have the latest lsp-mode installed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The client

Which client?

you don't need this if you

Then what should users do (e.g. modifying the config) in this case? Could you provide a detailed code snippet to elaborate?

Copy link
Member Author

@jcs090218 jcs090218 Sep 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which client?

The lsp-mode is the client implementation. 🤔

Then what should users do (e.g. modifying the config) in this case? Could you provide a detailed code snippet to elaborate?

Users should still use the snippet that has already been provided.

The note simply informs users that they do not need to customize or add a snippet to their configuration after 8.0.0 since it's built-in; otherwise, it is redundant.


## Change the configuration.

Read the [configuration](configuration.md) docs here.
Loading