-
-
Notifications
You must be signed in to change notification settings - Fork 844
refactor: replace deprecated tsconfck with get-tsconfig
#4367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2b64c08
chore: update agent docs
pi0 ca8bab3
refactor: replace deprecated `tsconfck` with `get-tsconfig`
pi0 746f824
up
pi0 f7632db
update tss example
pi0 feffede
chore: apply automated updates
autofix-ci[bot] 37c01a0
chore: apply automated updates (attempt 2/3)
autofix-ci[bot] c09b9d2
up
pi0 636bd03
up
pi0 0228481
up
pi0 6807b4e
up
pi0 cf47769
chore: apply automated updates
autofix-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,28 @@ | ||
| import type { NitroOptions } from "nitro/types"; | ||
| import type { TSConfig } from "pkg-types"; | ||
| import { join, resolve } from "pathe"; | ||
| import * as tsco from "tsconfck"; | ||
| import { parseTsconfig } from "get-tsconfig"; | ||
|
|
||
| const tsconfigCache = new Map<string, any>(); | ||
|
|
||
| export async function resolveTsconfig(options: NitroOptions) { | ||
| const root = resolve(options.rootDir || ".") + "/"; | ||
| if (!options.typescript.tsConfig) { | ||
| options.typescript.tsConfig = await loadTsconfig(root); | ||
| options.typescript.tsConfig = loadTsconfig(root); | ||
| } | ||
| } | ||
|
|
||
| async function loadTsconfig(root: string): Promise<TSConfig> { | ||
| const opts: tsco.TSConfckParseOptions = { | ||
| root, | ||
| cache: ((loadTsconfig as any)["__cache"] ??= new tsco.TSConfckCache()), | ||
| ignoreNodeModules: true, | ||
| }; | ||
| function loadTsconfig(root: string): TSConfig { | ||
| const tsConfigPath = join(root, "tsconfig.json"); | ||
| const parsed = await tsco.parse(tsConfigPath, opts).catch(() => undefined); | ||
| if (!parsed) return {} as TSConfig; | ||
| const { tsconfig, tsconfigFile } = parsed; | ||
| let tsconfig: TSConfig; | ||
| try { | ||
| tsconfig = parseTsconfig(tsConfigPath, tsconfigCache) as TSConfig; | ||
| } catch { | ||
| return {} as TSConfig; | ||
|
pi0 marked this conversation as resolved.
|
||
| } | ||
| tsconfig.compilerOptions ??= {}; | ||
| if (!tsconfig.compilerOptions.baseUrl) { | ||
| tsconfig.compilerOptions.baseUrl = resolve(tsconfigFile, ".."); | ||
| tsconfig.compilerOptions.baseUrl = resolve(tsConfigPath, ".."); | ||
| } | ||
| return tsconfig; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.