fix(config): detect vite.config.c[jt]s#4363
Merged
Merged
Conversation
|
@NaufalK25 is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
📝 WalkthroughWalkthrough
ChangesVite Config Extension Detection
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
vite.config.c[jt]s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
resolveBuilder'shasNitroViteConfig()only checkedvite.config.{ts,mts,js,mjs}when auto-detecting thevitebuilder, missing.cjs/.ctsconfigs.vite.config.cjsandvite.config.ctsas first-class config files (seeDEFAULT_CONFIG_FILESin vite's constants.ts, and the Vite config docs: "other JS and TS extensions are also supported"). Nitro's own builder detection was just out of sync with that list..cjsand.ctstoconfigExtsso avite.config.cjs/.ctscontaining thenitro()plugin is now correctly detected andbuilderdefaults to"vite".📝 Checklist