Fix depfile parser to support ? #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhasse
reviewed
Feb 4, 2025
The `?` is actually valid on Unix filesystems, as well as on Windows when it appears at the start of the path, as in `\\?\C:\foo` or `//?/C:/foo`. Before this patch, the depfile parser considered it as whitespace and would mistakenly decompose `//?/C:/foo` into two separate paths (`//` and `/C:/foo`) which broke Ninja incremental builds. The major change in in src/depfile_parser.in.cc Note that re2c version 3.1 was used to regenerate depfile_parser.cc from that file. Fixes ninja-build#2568
digit-google
force-pushed
the
fix-depfile-parser-for-win32-local-root-paths
branch
from
c574d1c to
e903357
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
?is actually valid on Unix filesystems, as well as on Windows when it appears at the start of the path, as in\\?\C:\fooor//?/C:/foo.Before this patch, the depfile parser considered it as whitespace and would mistakenly decompose
//?/C:/foointo two separate paths (//and/C:/foo) which broke Ninja incremental builds.The major change in in src/depfile_parser.in.cc
Note that re2c version 3.1 was used to regenerate depfile_parser.cc from that file.
Fixes #2568