Ensure tests do not leave stale files in current directory. #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am puzzled as to why |
digit-google
force-pushed
the
remove-stale-test-outputs
branch
from
423e682 to
a20170d
Compare
|
Ok, @jhasse , I have no idea what's going in with the failure to compile "unlink" / "_unlink" / "::_unlink" here with MSVC2017, any suggestion welcome, I am puzzled! |
|
No idea. My suggestion: #2338 I would use util.h though. |
This patch fixes a minor but annoying issue during development where some tests would leave stale files in the current directory. + Introduce new ScopedFilePath class to perform remove-on-scope-exit of a given file path. Fixes ninja-build#1583
digit-google
force-pushed
the
remove-stale-test-outputs
branch
from
a20170d to
eff5b44
Compare
|
I think I was using util.h in a previous version that was uploaded here, and still failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a minor but annoying issue during development where some tests would leave stale files in the current directory.
Fixes #1583