Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit autonat and kad features from the web-client #3247

Open
wants to merge 2 commits into
base: albatross
Choose a base branch
from

Conversation

sisou
Copy link
Member

@sisou sisou commented Jan 16, 2025

What's in this pull request?

Improve usage of feature flags throughout different crates to avoid bundling autonat and parts of kad functionality into the web-client (and I believe thus light client, too)

Pull request checklist

  • All tests pass. The project builds and runs.
  • I have resolved any merge conflicts.
  • I have resolved all clippy and rustfmt warnings.

@sisou sisou self-assigned this Jan 16, 2025
@Eligioo
Copy link
Member

Eligioo commented Jan 16, 2025

I would prefer to fix this by creating a new 'light' behaviour and gate that based on the target platform here instead of adding all these feature flags. It makes everything quite messy and difficult to maintain now.

This new light behaviour would omit all the stuff(autonat, kad, etc.) that are not necessary for a light client.

PR #3012 prepped this effort by detaching the events from the handlers.

@sisou
Copy link
Member Author

sisou commented Jan 16, 2025

OK fair enough, but I don't know anything about how that works, so someone else will have to tackle it. Is it a huge effort?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants