Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix skip block test #3181

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Fix skip block test #3181

merged 1 commit into from
Dec 6, 2024

Conversation

viquezclaudio
Copy link
Member

  • Modify skip block test to actually produce a skip block

...

This fixes #___.

Pull request checklist

  • All tests pass. The project builds and runs.
  • I have resolved any merge conflicts.
  • I have resolved all clippy and rustfmt warnings.

jsdanielh
jsdanielh reviewed Dec 5, 2024
View reviewed changes
validator/tests/mock.rs Outdated Show resolved Hide resolved
@viquezclaudio viquezclaudio force-pushed the viquezcl/fix_test branch 3 times, most recently from c76cd32 to 896c1c3 Compare December 6, 2024 20:13
jsdanielh
jsdanielh approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@jsdanielh jsdanielh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viquezclaudio @jsdanielh
Fix skip block unittest
a3831f2 
Fix the skip block unittest to actually produce skip blocks and verify this
@jsdanielh jsdanielh merged commit a3831f2 into albatross Dec 6, 2024
8 checks passed
@jsdanielh jsdanielh deleted the viquezcl/fix_test branch December 6, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsdanielh jsdanielh jsdanielh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viquezclaudio @jsdanielh