Remove incorrect implementation of DataStoreReadOps
#3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrxi
force-pushed
the
hrxi/remote_data_store_block_on
branch
from
8e7b270 to
d72bdc5
Compare
It's almost always incorrect to use it.
Previously, the function would try to block the whole thread whenever requesting something from other peers. This wasn't noticed since the implementation is only used in light clients that were **NOT** compiled for WASM. I noticed this implementation when reviewing #3159, which would have caused these thread blockings to continue for longer times.
hrxi
force-pushed
the
hrxi/remote_data_store_block_on
branch
from
1617f7a to
b4b0ff2
Compare
It has no WASM dependencies and is not broken unlike the thing it replaces.
hrxi
force-pushed
the
hrxi/remote_data_store_block_on
branch
from
b4b0ff2 to
eca46dc
Compare
jsdanielh
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the function would try to block the whole thread whenever requesting something from other peers.
This wasn't noticed since the implementation is only used in light clients that were NOT compiled for WASM.
I noticed this implementation when reviewing #3159, which would have caused these thread blockings to continue for longer times.