Add a plain list of services to web-client peer info structs
#3142
+59
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrxi
reviewed
Nov 24, 2024
| PreGenesisTransactions, | ||
|
|
||
| // Catch-all to not have to panic when new services are added | ||
| Unknown, |
There was a problem hiding this comment.
Is Unknown useful info for the web client? If not, I'd prefer to simply skip these.
The from function would return an Option<PlainService> and the PlainPeerInfo could then just ignore the Nones.
There was a problem hiding this comment.
I added it because I wanted to avoid silent failing. If we ever add more services, but forget to add them here, noone would ever find out.
Panicking or erroring is bad for backward-compatibility, so I think 'Unknown' is the next best thing.
That's also how I found #2986, because the new topics were not hidden.
jsdanielh
reviewed
Nov 25, 2024
jsdanielh
approved these changes
Dec 6, 2024
jsdanielh
force-pushed
the
soeren/web-client-peer-services
branch
from
c7d8108 to
c801676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
clippyandrustfmtwarnings.