web-client: Fix proofs being always set to empty string in Transactio…

…n.fromPlain

#3134 (released in v1.0.2) forced plain transaction proof deserialization to always deserialize a `PlainTransactionProof::Raw` variant to be compatible with PoW plain transactions, which didn't have a `proof.type` field.

Unfortunately I forgot to remove the empty string default for `PlainTransactionProof::Raw` when I renamed it from `PlainTransactionProof::Empty`.

web-client/extras/tests/Transaction.test.ts

@@ -88,7 +88,13 @@ describe('Transaction', () => {
             },
         };
 
-        expect(() => Transaction.fromPlain(plain as PlainTransactionDetails)).not.toThrow();
+        let tx: Transaction | undefined;
+        expect(() => tx = Transaction.fromPlain(plain as PlainTransactionDetails)).not.toThrow();
+        if (!tx) throw new Error('Transaction.fromPlain returned undefined');
+        const plain2 = tx.toPlain();
+        expect(plain2.proof).toEqual(plain.proof);
+        expect(plain2.size).toEqual(plain.size);
+        expect(plain2.valid).toEqual(plain.valid);
     });
 
     it('can deserialize PoW style plain transaction details', () => {
@@ -129,6 +135,13 @@ describe('Transaction', () => {
             },
         };
 
-        expect(() => Transaction.fromPlain(plain as unknown as PlainTransactionDetails)).not.toThrow();
+        let tx: Transaction | undefined;
+        expect(() => tx = Transaction.fromPlain(plain as unknown as PlainTransactionDetails)).not.toThrow();
+        if (!tx) throw new Error('Transaction.fromPlain returned undefined');
+
+        const plain2 = tx.toPlain();
+        expect(plain2.proof).toEqual(plain.proof);
+        expect(plain2.size).toEqual(plain.size);
+        expect(plain2.valid).toEqual(plain.valid);
     });
 });

web-client/src/common/transaction.rs

@@ -567,7 +567,7 @@ impl Transaction {
             from_network_id(NetworkId::from_str(&plain.network)?),
         )?;
         tx.set_proof(hex::decode(match plain.proof {
-            PlainTransactionProof::Raw(_) => "",
+            PlainTransactionProof::Raw(ref data) => &data.raw,
             PlainTransactionProof::Standard(ref data) => &data.raw,
             PlainTransactionProof::RegularTransfer(ref data) => &data.raw,
             PlainTransactionProof::TimeoutResolve(ref data) => &data.raw,