Make zkp errors more informative #14218
ii-cruzbuild+test.yml
on: pull_request
rustfmt
13s
check
1m 34s
test
30m 1s
clippy
1m 27s
web-client
4m 36s
web-client-lib
7m 5s
reconnect-test
12m 0s
Annotations
69 warnings
|
empty line after doc comment:
lib/src/extras/launcher.rs#L13
warning: empty line after doc comment
--> lib/src/extras/launcher.rs:13:1
|
13 | / ///
14 | |
| |_
15 | #[cfg(feature = "deadlock")]
16 | use crate::extras::deadlock::initialize_deadlock_detection;
| ------------------------------------------------------ the comment documents this import
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
= help: if the empty line is unintentional remove it
|
|
the following explicit lifetimes could be elided: 'a:
validator/src/aggregation/tendermint/state.rs#L72
warning: the following explicit lifetimes could be elided: 'a
--> validator/src/aggregation/tendermint/state.rs:72:6
|
72 | impl<'a> Debug for Votes<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
72 - impl<'a> Debug for Votes<'a> {
72 + impl Debug for Votes<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
validator/src/aggregation/tendermint/state.rs#L62
warning: the following explicit lifetimes could be elided: 'a
--> validator/src/aggregation/tendermint/state.rs:62:6
|
62 | impl<'a> Debug for BestVotes<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
62 - impl<'a> Debug for BestVotes<'a> {
62 + impl Debug for BestVotes<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
validator/src/aggregation/tendermint/state.rs#L51
warning: the following explicit lifetimes could be elided: 'a
--> validator/src/aggregation/tendermint/state.rs:51:6
|
51 | impl<'a, T> Debug for DisplayWrapper<'a, T>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
51 - impl<'a, T> Debug for DisplayWrapper<'a, T>
51 + impl<T> Debug for DisplayWrapper<'_, T>
|
|
|
the following explicit lifetimes could be elided: 'a:
blockchain-proxy/src/blockchain_proxy.rs#L97
warning: the following explicit lifetimes could be elided: 'a
--> blockchain-proxy/src/blockchain_proxy.rs:97:6
|
97 | impl<'a> AbstractBlockchain for BlockchainReadProxy<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
97 - impl<'a> AbstractBlockchain for BlockchainReadProxy<'a> {
97 + impl AbstractBlockchain for BlockchainReadProxy<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a, 'env:
blockchain/src/history/mmr_store.rs#L119
warning: the following explicit lifetimes could be elided: 'a, 'env
--> blockchain/src/history/mmr_store.rs:119:6
|
119 | impl<'a, 'env> Store<Blake2bHash> for MMRStore<'a, 'env> {
| ^^ ^^^^ ^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
119 - impl<'a, 'env> Store<Blake2bHash> for MMRStore<'a, 'env> {
119 + impl Store<Blake2bHash> for MMRStore<'_, '_> {
|
|
|
the following explicit lifetimes could be elided: 'txn:
blockchain/src/history/history_store_index.rs#L603
warning: the following explicit lifetimes could be elided: 'txn
--> blockchain/src/history/history_store_index.rs:603:6
|
603 | impl<'txn> Iterator for TxHashIterator<'txn> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
603 - impl<'txn> Iterator for TxHashIterator<'txn> {
603 + impl Iterator for TxHashIterator<'_> {
|
|
|
manually reimplementing `div_ceil`:
zkp-circuits/src/circuits/mod.rs#L23
warning: manually reimplementing `div_ceil`
--> zkp-circuits/src/circuits/mod.rs:23:23
|
23 | num_inputs += (num_bytes[i] * 8 + capacity - 1) / capacity;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(num_bytes[i] * 8).div_ceil(capacity)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
= note: `#[warn(clippy::manual_div_ceil)]` on by default
|
|
the following explicit lifetimes could be elided: 'store, 'tree, 'txn, 'txni, 'env:
primitives/account/src/data_store.rs#L85
warning: the following explicit lifetimes could be elided: 'store, 'tree, 'txn, 'txni, 'env
--> primitives/account/src/data_store.rs:85:6
|
85 | impl<'store, 'tree, 'txn, 'txni, 'env> DataStoreWrite<'store, 'tree, 'txn, 'txni, 'env> {
| ^^^^^^ ^^^^^ ^^^^ ^^^^^ ^^^^ ^^^^^^ ^^^^^ ^^^^ ^^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
85 - impl<'store, 'tree, 'txn, 'txni, 'env> DataStoreWrite<'store, 'tree, 'txn, 'txni, 'env> {
85 + impl DataStoreWrite<'_, '_, '_, '_, '_> {
|
|
|
the following explicit lifetimes could be elided: 'store, 'tree, 'env:
primitives/account/src/data_store.rs#L68
warning: the following explicit lifetimes could be elided: 'store, 'tree, 'env
--> primitives/account/src/data_store.rs:68:6
|
68 | impl<'store, 'tree, 'txn, 'env> DataStoreIterOps for DataStoreRead<'store, 'tree, 'txn, 'env> {
| ^^^^^^ ^^^^^ ^^^^ ^^^^^^ ^^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
68 - impl<'store, 'tree, 'txn, 'env> DataStoreIterOps for DataStoreRead<'store, 'tree, 'txn, 'env> {
68 + impl<'txn> DataStoreIterOps for DataStoreRead<'_, '_, 'txn, '_> {
|
|
|
the following explicit lifetimes could be elided: 'store, 'tree, 'txn, 'env:
primitives/account/src/data_store.rs#L62
warning: the following explicit lifetimes could be elided: 'store, 'tree, 'txn, 'env
--> primitives/account/src/data_store.rs:62:6
|
62 | impl<'store, 'tree, 'txn, 'env> DataStoreReadOps for DataStoreRead<'store, 'tree, 'txn, 'env> {
| ^^^^^^ ^^^^^ ^^^^ ^^^^ ^^^^^^ ^^^^^ ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
62 - impl<'store, 'tree, 'txn, 'env> DataStoreReadOps for DataStoreRead<'store, 'tree, 'txn, 'env> {
62 + impl DataStoreReadOps for DataStoreRead<'_, '_, '_, '_> {
|
|
|
the following explicit lifetimes could be elided: 'write, 'store, 'tree, 'txn, 'txni, 'env:
primitives/account/src/account/staking_contract/store.rs#L131
warning: the following explicit lifetimes could be elided: 'write, 'store, 'tree, 'txn, 'txni, 'env
--> primitives/account/src/account/staking_contract/store.rs:131:6
|
131 | impl<'write, 'store, 'tree, 'txn, 'txni, 'env> StakingContractStoreReadOps
| ^^^^^^ ^^^^^^ ^^^^^ ^^^^ ^^^^^ ^^^^
132 | for StakingContractStoreWrite<'write, 'store, 'tree, 'txn, 'txni, 'env>
| ^^^^^^ ^^^^^^ ^^^^^ ^^^^ ^^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
131 ~ impl StakingContractStoreReadOps
132 ~ for StakingContractStoreWrite<'_, '_, '_, '_, '_, '_>
|
|
|
the following explicit lifetimes could be elided: 'read:
primitives/account/src/account/staking_contract/store.rs#L73
warning: the following explicit lifetimes could be elided: 'read
--> primitives/account/src/account/staking_contract/store.rs:73:6
|
73 | impl<'read, T: DataStoreReadOps + DataStoreIterOps> StakingContractStoreRead<'read, T> {
| ^^^^^ ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
73 - impl<'read, T: DataStoreReadOps + DataStoreIterOps> StakingContractStoreRead<'read, T> {
73 + impl<T: DataStoreReadOps + DataStoreIterOps> StakingContractStoreRead<'_, T> {
|
|
|
the following explicit lifetimes could be elided: 'read:
primitives/account/src/account/staking_contract/store.rs#L57
warning: the following explicit lifetimes could be elided: 'read
--> primitives/account/src/account/staking_contract/store.rs:57:6
|
57 | impl<'read, T: DataStoreReadOps> StakingContractStoreReadOps
| ^^^^^
58 | for StakingContractStoreRead<'read, T>
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
57 ~ impl<T: DataStoreReadOps> StakingContractStoreReadOps
58 ~ for StakingContractStoreRead<'_, T>
|
|
|
the following explicit lifetimes could be elided: 'store, 'tree, 'txn, 'txni, 'env:
primitives/account/src/data_store.rs#L85
warning: the following explicit lifetimes could be elided: 'store, 'tree, 'txn, 'txni, 'env
--> primitives/account/src/data_store.rs:85:6
|
85 | impl<'store, 'tree, 'txn, 'txni, 'env> DataStoreWrite<'store, 'tree, 'txn, 'txni, 'env> {
| ^^^^^^ ^^^^^ ^^^^ ^^^^^ ^^^^ ^^^^^^ ^^^^^ ^^^^ ^^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
85 - impl<'store, 'tree, 'txn, 'txni, 'env> DataStoreWrite<'store, 'tree, 'txn, 'txni, 'env> {
85 + impl DataStoreWrite<'_, '_, '_, '_, '_> {
|
|
|
the following explicit lifetimes could be elided: 'store, 'tree, 'env:
primitives/account/src/data_store.rs#L68
warning: the following explicit lifetimes could be elided: 'store, 'tree, 'env
--> primitives/account/src/data_store.rs:68:6
|
68 | impl<'store, 'tree, 'txn, 'env> DataStoreIterOps for DataStoreRead<'store, 'tree, 'txn, 'env> {
| ^^^^^^ ^^^^^ ^^^^ ^^^^^^ ^^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
68 - impl<'store, 'tree, 'txn, 'env> DataStoreIterOps for DataStoreRead<'store, 'tree, 'txn, 'env> {
68 + impl<'txn> DataStoreIterOps for DataStoreRead<'_, '_, 'txn, '_> {
|
|
|
the following explicit lifetimes could be elided: 'store, 'tree, 'txn, 'env:
primitives/account/src/data_store.rs#L62
warning: the following explicit lifetimes could be elided: 'store, 'tree, 'txn, 'env
--> primitives/account/src/data_store.rs:62:6
|
62 | impl<'store, 'tree, 'txn, 'env> DataStoreReadOps for DataStoreRead<'store, 'tree, 'txn, 'env> {
| ^^^^^^ ^^^^^ ^^^^ ^^^^ ^^^^^^ ^^^^^ ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
62 - impl<'store, 'tree, 'txn, 'env> DataStoreReadOps for DataStoreRead<'store, 'tree, 'txn, 'env> {
62 + impl DataStoreReadOps for DataStoreRead<'_, '_, '_, '_> {
|
|
|
the following explicit lifetimes could be elided: 'write, 'store, 'tree, 'txn, 'txni, 'env:
primitives/account/src/account/staking_contract/store.rs#L131
warning: the following explicit lifetimes could be elided: 'write, 'store, 'tree, 'txn, 'txni, 'env
--> primitives/account/src/account/staking_contract/store.rs:131:6
|
131 | impl<'write, 'store, 'tree, 'txn, 'txni, 'env> StakingContractStoreReadOps
| ^^^^^^ ^^^^^^ ^^^^^ ^^^^ ^^^^^ ^^^^
132 | for StakingContractStoreWrite<'write, 'store, 'tree, 'txn, 'txni, 'env>
| ^^^^^^ ^^^^^^ ^^^^^ ^^^^ ^^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
131 ~ impl StakingContractStoreReadOps
132 ~ for StakingContractStoreWrite<'_, '_, '_, '_, '_, '_>
|
|
|
the following explicit lifetimes could be elided: 'read:
primitives/account/src/account/staking_contract/store.rs#L73
warning: the following explicit lifetimes could be elided: 'read
--> primitives/account/src/account/staking_contract/store.rs:73:6
|
73 | impl<'read, T: DataStoreReadOps + DataStoreIterOps> StakingContractStoreRead<'read, T> {
| ^^^^^ ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
73 - impl<'read, T: DataStoreReadOps + DataStoreIterOps> StakingContractStoreRead<'read, T> {
73 + impl<T: DataStoreReadOps + DataStoreIterOps> StakingContractStoreRead<'_, T> {
|
|
|
the following explicit lifetimes could be elided: 'read:
primitives/account/src/account/staking_contract/store.rs#L57
warning: the following explicit lifetimes could be elided: 'read
--> primitives/account/src/account/staking_contract/store.rs:57:6
|
57 | impl<'read, T: DataStoreReadOps> StakingContractStoreReadOps
| ^^^^^
58 | for StakingContractStoreRead<'read, T>
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
57 ~ impl<T: DataStoreReadOps> StakingContractStoreReadOps
58 ~ for StakingContractStoreRead<'_, T>
|
|
|
the following explicit lifetimes could be elided: 'a:
validator-network/src/single_response_requester.rs#L90
warning: the following explicit lifetimes could be elided: 'a
--> validator-network/src/single_response_requester.rs:90:6
|
90 | impl<'a, TValidatorNetwork, TRequest, TOutput> Future
| ^^
91 | for SingleResponseRequester<'a, TValidatorNetwork, TRequest, TOutput>
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
90 ~ impl<TValidatorNetwork, TRequest, TOutput> Future
91 ~ for SingleResponseRequester<'_, TValidatorNetwork, TRequest, TOutput>
|
|
|
the following explicit lifetimes could be elided: 'a:
validator-network/src/single_response_requester.rs#L32
warning: the following explicit lifetimes could be elided: 'a
--> validator-network/src/single_response_requester.rs:32:6
|
32 | impl<'a, TValidatorNetwork, TRequest, TOutput>
| ^^
33 | SingleResponseRequester<'a, TValidatorNetwork, TRequest, TOutput>
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
32 ~ impl<TValidatorNetwork, TRequest, TOutput>
33 ~ SingleResponseRequester<'_, TValidatorNetwork, TRequest, TOutput>
|
|
|
the following explicit lifetimes could be elided: 'txn:
primitives/trie/src/trie.rs#L1628
warning: the following explicit lifetimes could be elided: 'txn
--> primitives/trie/src/trie.rs:1628:6
|
1628 | impl<'txn, T: TrieTable, D: Deserialize> Iterator for TrieNodeIter<'txn, T, D> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
1628 - impl<'txn, T: TrieTable, D: Deserialize> Iterator for TrieNodeIter<'txn, T, D> {
1628 + impl<T: TrieTable, D: Deserialize> Iterator for TrieNodeIter<'_, T, D> {
|
|
|
the following explicit lifetimes could be elided: 'txn:
primitives/trie/src/trie.rs#L1610
warning: the following explicit lifetimes could be elided: 'txn
--> primitives/trie/src/trie.rs:1610:6
|
1610 | impl<'txn, T: TrieTable, D> TrieNodeIter<'txn, T, D> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
1610 - impl<'txn, T: TrieTable, D> TrieNodeIter<'txn, T, D> {
1610 + impl<T: TrieTable, D> TrieNodeIter<'_, T, D> {
|
|
|
the following explicit lifetimes could be elided: 'txn:
primitives/trie/src/transaction.rs#L121
warning: the following explicit lifetimes could be elided: 'txn
--> primitives/trie/src/transaction.rs:121:6
|
121 | impl<'txn, 'env> ops::Deref for WriteTransactionProxy<'txn, 'env> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
121 - impl<'txn, 'env> ops::Deref for WriteTransactionProxy<'txn, 'env> {
121 + impl<'env> ops::Deref for WriteTransactionProxy<'_, 'env> {
|
|
|
the following explicit lifetimes could be elided: 'txn:
primitives/trie/src/transaction.rs#L63
warning: the following explicit lifetimes could be elided: 'txn
--> primitives/trie/src/transaction.rs:63:6
|
63 | impl<'txn, 'env> WriteTransactionProxy<'txn, 'env> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
63 - impl<'txn, 'env> WriteTransactionProxy<'txn, 'env> {
63 + impl<'env> WriteTransactionProxy<'_, 'env> {
|
|
|
the following explicit lifetimes could be elided: 'txn, 'env:
primitives/trie/src/transaction.rs#L31
warning: the following explicit lifetimes could be elided: 'txn, 'env
--> primitives/trie/src/transaction.rs:31:6
|
31 | impl<'txn, 'env> TransactionExt for WriteTransactionProxy<'txn, 'env> {
| ^^^^ ^^^^ ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
31 - impl<'txn, 'env> TransactionExt for WriteTransactionProxy<'txn, 'env> {
31 + impl TransactionExt for WriteTransactionProxy<'_, '_> {
|
|
|
the following explicit lifetimes could be elided: 'db:
primitives/trie/src/transaction.rs#L23
warning: the following explicit lifetimes could be elided: 'db
--> primitives/trie/src/transaction.rs:23:6
|
23 | impl<'db> TransactionExt for MdbxReadTransaction<'db> {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
23 - impl<'db> TransactionExt for MdbxReadTransaction<'db> {
23 + impl TransactionExt for MdbxReadTransaction<'_> {
|
|
|
the following explicit lifetimes could be elided: 'txn:
primitives/trie/src/trie.rs#L1628
warning: the following explicit lifetimes could be elided: 'txn
--> primitives/trie/src/trie.rs:1628:6
|
1628 | impl<'txn, T: TrieTable, D: Deserialize> Iterator for TrieNodeIter<'txn, T, D> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
1628 - impl<'txn, T: TrieTable, D: Deserialize> Iterator for TrieNodeIter<'txn, T, D> {
1628 + impl<T: TrieTable, D: Deserialize> Iterator for TrieNodeIter<'_, T, D> {
|
|
|
the following explicit lifetimes could be elided: 'txn:
primitives/trie/src/trie.rs#L1610
warning: the following explicit lifetimes could be elided: 'txn
--> primitives/trie/src/trie.rs:1610:6
|
1610 | impl<'txn, T: TrieTable, D> TrieNodeIter<'txn, T, D> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
1610 - impl<'txn, T: TrieTable, D> TrieNodeIter<'txn, T, D> {
1610 + impl<T: TrieTable, D> TrieNodeIter<'_, T, D> {
|
|
|
the following explicit lifetimes could be elided: 'txn:
primitives/trie/src/transaction.rs#L121
warning: the following explicit lifetimes could be elided: 'txn
--> primitives/trie/src/transaction.rs:121:6
|
121 | impl<'txn, 'env> ops::Deref for WriteTransactionProxy<'txn, 'env> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
121 - impl<'txn, 'env> ops::Deref for WriteTransactionProxy<'txn, 'env> {
121 + impl<'env> ops::Deref for WriteTransactionProxy<'_, 'env> {
|
|
|
the following explicit lifetimes could be elided: 'txn:
primitives/trie/src/transaction.rs#L63
warning: the following explicit lifetimes could be elided: 'txn
--> primitives/trie/src/transaction.rs:63:6
|
63 | impl<'txn, 'env> WriteTransactionProxy<'txn, 'env> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
63 - impl<'txn, 'env> WriteTransactionProxy<'txn, 'env> {
63 + impl<'env> WriteTransactionProxy<'_, 'env> {
|
|
|
the following explicit lifetimes could be elided: 'txn, 'env:
primitives/trie/src/transaction.rs#L31
warning: the following explicit lifetimes could be elided: 'txn, 'env
--> primitives/trie/src/transaction.rs:31:6
|
31 | impl<'txn, 'env> TransactionExt for WriteTransactionProxy<'txn, 'env> {
| ^^^^ ^^^^ ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
31 - impl<'txn, 'env> TransactionExt for WriteTransactionProxy<'txn, 'env> {
31 + impl TransactionExt for WriteTransactionProxy<'_, '_> {
|
|
|
the following explicit lifetimes could be elided: 'db:
primitives/trie/src/transaction.rs#L23
warning: the following explicit lifetimes could be elided: 'db
--> primitives/trie/src/transaction.rs:23:6
|
23 | impl<'db> TransactionExt for MdbxReadTransaction<'db> {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
23 - impl<'db> TransactionExt for MdbxReadTransaction<'db> {
23 + impl TransactionExt for MdbxReadTransaction<'_> {
|
|
|
manually reimplementing `div_ceil`:
zkp-primitives/pedersen-generators/src/lib.rs#L49
warning: manually reimplementing `div_ceil`
--> zkp-primitives/pedersen-generators/src/lib.rs:49:31
|
49 | let generators_needed_b = (num_bits_per_leaf + capacity - 1) / capacity + 1;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `num_bits_per_leaf.div_ceil(capacity)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
= note: `#[warn(clippy::manual_div_ceil)]` on by default
|
|
the following explicit lifetimes could be elided: 'a:
primitives/src/trie/trie_node.rs#L349
warning: the following explicit lifetimes could be elided: 'a
--> primitives/src/trie/trie_node.rs:349:6
|
349 | impl<'a> DoubleEndedIterator for IterMut<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
349 - impl<'a> DoubleEndedIterator for IterMut<'a> {
349 + impl DoubleEndedIterator for IterMut<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
primitives/src/trie/trie_node.rs#L312
warning: the following explicit lifetimes could be elided: 'a
--> primitives/src/trie/trie_node.rs:312:6
|
312 | impl<'a> DoubleEndedIterator for Iter<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
312 - impl<'a> DoubleEndedIterator for Iter<'a> {
312 + impl DoubleEndedIterator for Iter<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
primitives/src/trie/trie_node.rs#L349
warning: the following explicit lifetimes could be elided: 'a
--> primitives/src/trie/trie_node.rs:349:6
|
349 | impl<'a> DoubleEndedIterator for IterMut<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
349 - impl<'a> DoubleEndedIterator for IterMut<'a> {
349 + impl DoubleEndedIterator for IterMut<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
primitives/src/trie/trie_node.rs#L312
warning: the following explicit lifetimes could be elided: 'a
--> primitives/src/trie/trie_node.rs:312:6
|
312 | impl<'a> DoubleEndedIterator for Iter<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
312 - impl<'a> DoubleEndedIterator for Iter<'a> {
312 + impl DoubleEndedIterator for Iter<'_> {
|
|
|
manually reimplementing `div_ceil`:
primitives/src/policy.rs#L271
warning: manually reimplementing `div_ceil`
--> primitives/src/policy.rs:271:13
|
271 | (block_number + blocks_per_batch - 1) / blocks_per_batch
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `block_number.div_ceil(blocks_per_batch)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
|
|
manually reimplementing `div_ceil`:
primitives/src/policy.rs#L242
warning: manually reimplementing `div_ceil`
--> primitives/src/policy.rs:242:13
|
242 | (block_number + blocks_per_epoch - 1) / blocks_per_epoch
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `block_number.div_ceil(blocks_per_epoch)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
|
|
manually reimplementing `div_ceil`:
primitives/src/policy.rs#L88
warning: manually reimplementing `div_ceil`
--> primitives/src/policy.rs:88:33
|
88 | pub const F_PLUS_ONE: u16 = (Self::SLOTS + 3 - 1) / 3;
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `Self::SLOTS.div_ceil(3)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
|
|
manually reimplementing `div_ceil`:
primitives/src/policy.rs#L82
warning: manually reimplementing `div_ceil`
--> primitives/src/policy.rs:82:37
|
82 | pub const TWO_F_PLUS_ONE: u16 = (2 * Self::SLOTS + 3 - 1) / 3;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(2 * Self::SLOTS).div_ceil(3)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
= note: `#[warn(clippy::manual_div_ceil)]` on by default
|
|
the following explicit lifetimes could be elided: 'de:
primitives/src/key_nibbles.rs#L432
warning: the following explicit lifetimes could be elided: 'de
--> primitives/src/key_nibbles.rs:432:10
|
432 | impl<'de> Visitor<'de> for KeyNibblesBytesVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
432 - impl<'de> Visitor<'de> for KeyNibblesBytesVisitor {
432 + impl Visitor<'_> for KeyNibblesBytesVisitor {
|
|
|
manually reimplementing `div_ceil`:
primitives/src/policy.rs#L271
warning: manually reimplementing `div_ceil`
--> primitives/src/policy.rs:271:13
|
271 | (block_number + blocks_per_batch - 1) / blocks_per_batch
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `block_number.div_ceil(blocks_per_batch)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
|
|
manually reimplementing `div_ceil`:
primitives/src/policy.rs#L242
warning: manually reimplementing `div_ceil`
--> primitives/src/policy.rs:242:13
|
242 | (block_number + blocks_per_epoch - 1) / blocks_per_epoch
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `block_number.div_ceil(blocks_per_epoch)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
|
|
manually reimplementing `div_ceil`:
primitives/src/policy.rs#L88
warning: manually reimplementing `div_ceil`
--> primitives/src/policy.rs:88:33
|
88 | pub const F_PLUS_ONE: u16 = (Self::SLOTS + 3 - 1) / 3;
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `Self::SLOTS.div_ceil(3)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
|
|
manually reimplementing `div_ceil`:
primitives/src/policy.rs#L82
warning: manually reimplementing `div_ceil`
--> primitives/src/policy.rs:82:37
|
82 | pub const TWO_F_PLUS_ONE: u16 = (2 * Self::SLOTS + 3 - 1) / 3;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(2 * Self::SLOTS).div_ceil(3)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
= note: `#[warn(clippy::manual_div_ceil)]` on by default
|
|
the following explicit lifetimes could be elided: 'de:
primitives/src/key_nibbles.rs#L432
warning: the following explicit lifetimes could be elided: 'de
--> primitives/src/key_nibbles.rs:432:10
|
432 | impl<'de> Visitor<'de> for KeyNibblesBytesVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
432 - impl<'de> Visitor<'de> for KeyNibblesBytesVisitor {
432 + impl Visitor<'_> for KeyNibblesBytesVisitor {
|
|
|
the following explicit lifetimes could be elided: 'a:
hash/src/lib.rs#L358
warning: the following explicit lifetimes could be elided: 'a
--> hash/src/lib.rs:358:6
|
358 | impl<'a, T: SerializeContent + ?Sized> SerializeContent for &'a T {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
358 - impl<'a, T: SerializeContent + ?Sized> SerializeContent for &'a T {
358 + impl<T: SerializeContent + ?Sized> SerializeContent for &T {
|
|
|
the following explicit lifetimes could be elided: 'a:
hash/src/lib.rs#L358
warning: the following explicit lifetimes could be elided: 'a
--> hash/src/lib.rs:358:6
|
358 | impl<'a, T: SerializeContent + ?Sized> SerializeContent for &'a T {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
358 - impl<'a, T: SerializeContent + ?Sized> SerializeContent for &'a T {
358 + impl<T: SerializeContent + ?Sized> SerializeContent for &T {
|
|
|
the following explicit lifetimes could be elided: 'a:
hash/src/hmac.rs#L11
warning: the following explicit lifetimes could be elided: 'a
--> hash/src/hmac.rs:11:6
|
11 | impl<'a> Key<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
11 - impl<'a> Key<'a> {
11 + impl Key<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
hash/src/hmac.rs#L11
warning: the following explicit lifetimes could be elided: 'a
--> hash/src/hmac.rs:11:6
|
11 | impl<'a> Key<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
11 - impl<'a> Key<'a> {
11 + impl Key<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
primitives/mmr/src/store/memory.rs#L77
warning: the following explicit lifetimes could be elided: 'a
--> primitives/mmr/src/store/memory.rs:77:6
|
77 | impl<'a, H: Clone, S: Store<H>> Store<H> for MemoryTransaction<'a, H, S> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
77 - impl<'a, H: Clone, S: Store<H>> Store<H> for MemoryTransaction<'a, H, S> {
77 + impl<H: Clone, S: Store<H>> Store<H> for MemoryTransaction<'_, H, S> {
|
|
|
the following explicit lifetimes could be elided: 'a:
primitives/mmr/src/store/memory.rs#L77
warning: the following explicit lifetimes could be elided: 'a
--> primitives/mmr/src/store/memory.rs:77:6
|
77 | impl<'a, H: Clone, S: Store<H>> Store<H> for MemoryTransaction<'a, H, S> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
77 - impl<'a, H: Clone, S: Store<H>> Store<H> for MemoryTransaction<'a, H, S> {
77 + impl<H: Clone, S: Store<H>> Store<H> for MemoryTransaction<'_, H, S> {
|
|
|
the following explicit lifetimes could be elided: 'txn:
database/src/mdbx/iterators.rs#L36
warning: the following explicit lifetimes could be elided: 'txn
--> database/src/mdbx/iterators.rs:36:6
|
36 | impl<'txn, T: Table> Iterator for IntoIterProxy<'txn, T> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
36 - impl<'txn, T: Table> Iterator for IntoIterProxy<'txn, T> {
36 + impl<T: Table> Iterator for IntoIterProxy<'_, T> {
|
|
|
the following explicit lifetimes could be elided: 'txn:
database/src/mdbx/iterators.rs#L16
warning: the following explicit lifetimes could be elided: 'txn
--> database/src/mdbx/iterators.rs:16:6
|
16 | impl<'txn, Kind: TransactionKind, T: Table> Iterator for IntoIter<'txn, Kind, T> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
16 - impl<'txn, Kind: TransactionKind, T: Table> Iterator for IntoIter<'txn, Kind, T> {
16 + impl<Kind: TransactionKind, T: Table> Iterator for IntoIter<'_, Kind, T> {
|
|
|
the following explicit lifetimes could be elided: 'txn:
database/src/mdbx/iterators.rs#L36
warning: the following explicit lifetimes could be elided: 'txn
--> database/src/mdbx/iterators.rs:36:6
|
36 | impl<'txn, T: Table> Iterator for IntoIterProxy<'txn, T> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
36 - impl<'txn, T: Table> Iterator for IntoIterProxy<'txn, T> {
36 + impl<T: Table> Iterator for IntoIterProxy<'_, T> {
|
|
|
the following explicit lifetimes could be elided: 'txn:
database/src/mdbx/iterators.rs#L16
warning: the following explicit lifetimes could be elided: 'txn
--> database/src/mdbx/iterators.rs:16:6
|
16 | impl<'txn, Kind: TransactionKind, T: Table> Iterator for IntoIter<'txn, Kind, T> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
16 - impl<'txn, Kind: TransactionKind, T: Table> Iterator for IntoIter<'txn, Kind, T> {
16 + impl<Kind: TransactionKind, T: Table> Iterator for IntoIter<'_, Kind, T> {
|
|
|
the following explicit lifetimes could be elided: 'txn:
database/src/mdbx/cursor.rs#L289
warning: the following explicit lifetimes could be elided: 'txn
--> database/src/mdbx/cursor.rs:289:6
|
289 | impl<'txn, T: Table> Clone for CursorProxy<'txn, T> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
289 - impl<'txn, T: Table> Clone for CursorProxy<'txn, T> {
289 + impl<T: Table> Clone for CursorProxy<'_, T> {
|
|
|
the following explicit lifetimes could be elided: 'txn:
database/src/mdbx/cursor.rs#L241
warning: the following explicit lifetimes could be elided: 'txn
--> database/src/mdbx/cursor.rs:241:6
|
241 | impl<'txn, Kind: TransactionKind, T: Table> Clone for MdbxCursor<'txn, Kind, T> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
241 - impl<'txn, Kind: TransactionKind, T: Table> Clone for MdbxCursor<'txn, Kind, T> {
241 + impl<Kind: TransactionKind, T: Table> Clone for MdbxCursor<'_, Kind, T> {
|
|
|
unneeded `return` statement:
database/src/mdbx/cursor.rs#L226
warning: unneeded `return` statement
--> database/src/mdbx/cursor.rs:226:13
|
226 | return self.cursor.iter_dup_of::<(), ()>(&key).count();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
226 - return self.cursor.iter_dup_of::<(), ()>(&key).count();
226 + self.cursor.iter_dup_of::<(), ()>(&key).count()
|
|
|
the following explicit lifetimes could be elided: 'a, 'b:
serde/src/lib.rs#L246
warning: the following explicit lifetimes could be elided: 'a, 'b
--> serde/src/lib.rs:246:14
|
246 | impl<'a, 'b, W: Write> postcard::ser_flavors::Flavor for Wrapper<'a, 'b, W> {
| ^^ ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
246 - impl<'a, 'b, W: Write> postcard::ser_flavors::Flavor for Wrapper<'a, 'b, W> {
246 + impl<W: Write> postcard::ser_flavors::Flavor for Wrapper<'_, '_, W> {
|
|
|
the following explicit lifetimes could be elided: 'txn:
database/src/mdbx/cursor.rs#L34
warning: the following explicit lifetimes could be elided: 'txn
--> database/src/mdbx/cursor.rs:34:6
|
34 | impl<'txn, Kind: TransactionKind, T: DupTable> MdbxCursor<'txn, Kind, T>
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
34 - impl<'txn, Kind: TransactionKind, T: DupTable> MdbxCursor<'txn, Kind, T>
34 + impl<Kind: TransactionKind, T: DupTable> MdbxCursor<'_, Kind, T>
|
|
|
the following explicit lifetimes could be elided: 'txn:
database/src/mdbx/cursor.rs#L289
warning: the following explicit lifetimes could be elided: 'txn
--> database/src/mdbx/cursor.rs:289:6
|
289 | impl<'txn, T: Table> Clone for CursorProxy<'txn, T> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
289 - impl<'txn, T: Table> Clone for CursorProxy<'txn, T> {
289 + impl<T: Table> Clone for CursorProxy<'_, T> {
|
|
|
the following explicit lifetimes could be elided: 'txn:
database/src/mdbx/cursor.rs#L241
warning: the following explicit lifetimes could be elided: 'txn
--> database/src/mdbx/cursor.rs:241:6
|
241 | impl<'txn, Kind: TransactionKind, T: Table> Clone for MdbxCursor<'txn, Kind, T> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
241 - impl<'txn, Kind: TransactionKind, T: Table> Clone for MdbxCursor<'txn, Kind, T> {
241 + impl<Kind: TransactionKind, T: Table> Clone for MdbxCursor<'_, Kind, T> {
|
|
|
unneeded `return` statement:
database/src/mdbx/cursor.rs#L226
warning: unneeded `return` statement
--> database/src/mdbx/cursor.rs:226:13
|
226 | return self.cursor.iter_dup_of::<(), ()>(&key).count();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
226 - return self.cursor.iter_dup_of::<(), ()>(&key).count();
226 + self.cursor.iter_dup_of::<(), ()>(&key).count()
|
|
|
the following explicit lifetimes could be elided: 'a, 'b:
serde/src/lib.rs#L246
warning: the following explicit lifetimes could be elided: 'a, 'b
--> serde/src/lib.rs:246:14
|
246 | impl<'a, 'b, W: Write> postcard::ser_flavors::Flavor for Wrapper<'a, 'b, W> {
| ^^ ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
246 - impl<'a, 'b, W: Write> postcard::ser_flavors::Flavor for Wrapper<'a, 'b, W> {
246 + impl<W: Write> postcard::ser_flavors::Flavor for Wrapper<'_, '_, W> {
|
|
|
the following explicit lifetimes could be elided: 'txn:
database/src/mdbx/cursor.rs#L34
warning: the following explicit lifetimes could be elided: 'txn
--> database/src/mdbx/cursor.rs:34:6
|
34 | impl<'txn, Kind: TransactionKind, T: DupTable> MdbxCursor<'txn, Kind, T>
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
34 - impl<'txn, Kind: TransactionKind, T: DupTable> MdbxCursor<'txn, Kind, T>
34 + impl<Kind: TransactionKind, T: DupTable> MdbxCursor<'_, Kind, T>
|
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
reconnect-test-logs
|
302 KB |
|