-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure-pipelines.yml: test important packages #769
base: master
Are you sure you want to change the base?
Conversation
6af1d55
to
31c8bf4
Compare
31c8bf4
to
2af79eb
Compare
This works with devel, so should work with us too (in theory)
Do we need another CI for this? Can't we do it in travis? |
To be honest, I wonder whether this should even be done every commit. It seems like it would be very flaky. We should have it run continuously every day or so instead to give us general signal, but every commit sounds like a pain. |
It usually takes over 10 mins for an output from
It appears to me that nimble has been failing the "important packages test" for a while: https://dev.azure.com/alaviss/Nim/_build/results?buildId=280&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=356bb04c-cb4a-5f04-82ca-d3b102917eba I can reproduce the errors, and they aren't there with stable nimble (which is used by Nim devel for testing). So yes, I think we should do this kind of testing more often. |
If we can get a list of packages that Nimble |
if it becomes too flaky we can simply add:
=>
but this is strictly better than not testing at all |
It can give good signal, but I'd rather it not block PRs/commits which is why I think it should be run separately. Also, I would prefer if it didn't depend on |
it wouldn't block anything because of the |
That could work but only if we can avoid noise in GitHub's UI. |
as long as a task succeeds (eg via |
We now have Github Actions, can we do it there? |
To be honest, I'm still preferring a separate repo for this so that we can avoid delaying the CI status. |
No description provided.