Haiku: Add support #193
Open
Haiku: Add support #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw in this port libraries are stored in lib/ and not in bin/ (except game, which in hl2/bin for example) which is already in haiku's LIBRARY_PATH so we needn't crutches in launcher_main |
er2off
commented
Feb 16, 2023
| @@ -109,7 +109,7 @@ typedef unsigned short ushort; | |||
|
|
|||
| template < class A > | |||
| static const char *GetFmtStr( int nRadix = 10, bool bPrint = true ) { Assert( 0 ); return ""; } | |||
| #if defined( LINUX ) || defined( __clang__ ) || ( defined( _MSC_VER ) && _MSC_VER >= 1900 ) | |||
| #if defined( LINUX ) || defined( __clang__ ) || ( defined( _MSC_VER ) && _MSC_VER >= 1900 ) || defined(PLATFORM_HAIKU) | |||
There was a problem hiding this comment.
maybe better detect gcc here? maybe see later if it will be needed
er2off
commented
Feb 16, 2023
| @@ -161,7 +161,7 @@ bool CVGuiSystemModuleLoader::LoadPlatformModules(CreateInterfaceFn *factorylist | |||
| { | |||
| dllPath = it->GetString("dll_osx"); | |||
| } | |||
| else if ( IsLinux() || IsBSD() ) | |||
| else if ( IsPosix() ) | |||
There was a problem hiding this comment.
is better to just use ifdefs?
er2off
commented
Feb 16, 2023
Comment on lines
+45
to
+46
| if bld.env.DEST_OS == 'haiku': | ||
| defines += ['HAVE_FC=0'] |
There was a problem hiding this comment.
TODO: Solve fontconfig can't find fonts
nillerusr
reviewed
Feb 27, 2023
|
Тем не менее, его даже freebsd использует, и, думаю, macos тоже, всем очень весело, особенно вафу
|
|
не туда, спасибо email |
nillerusr
force-pushed
the
master
branch
19 times, most recently
from
a65e792
to
92028d4
Compare
nillerusr
force-pushed
the
master
branch
17 times, most recently
from
2ce4d63
to
0114bd7
Compare
er2off
added a commit
to er2off/source-engine
that referenced
this pull request
Apr 24, 2023
Closes nillerusr#72 and uses some patches from nillerusr#193 for better portability between UNIXes. Also this patch replaces so many NULLs with 0 or '\0' because musl headers redefines it and anyway it is better practice. Moreover, due to very "cool" code from Valve, some modules comes with disabled fortify which distributes with build-base in Alpine (fortify is something like compile-time checking for memory bounds)
nillerusr
force-pushed
the
master
branch
3 times, most recently
from
358c568
to
b38bccd
Compare
er2off
added a commit
to er2off/source-engine
that referenced
this pull request
Apr 24, 2023
Closes nillerusr#72 and uses some patches from nillerusr#193 for better portability between UNIXes. Also this patch replaces so many NULLs with 0 or '\0' because musl headers redefines it and anyway it is better practice. Moreover, due to very "cool" code from Valve, some modules comes with disabled fortify which distributes with build-base in Alpine (fortify is something like compile-time checking for memory bounds)
Closed
nillerusr
force-pushed
the
master
branch
2 times, most recently
from
dfaccca
to
f2fa241
Compare
er2off
added a commit
to er2off/source-engine
that referenced
this pull request
Apr 24, 2023
Closes nillerusr#72 and uses some patches from nillerusr#193 for better portability between UNIXes. Also this patch replaces so many NULLs with 0 or '\0' because musl headers redefines it and anyway it is better practice. Moreover, due to very "cool" code from Valve, some modules comes with disabled fortify which distributes with build-base in Alpine (fortify is something like compile-time checking for memory bounds)
er2off
added a commit
to er2off/source-engine
that referenced
this pull request
Apr 24, 2023
Closes nillerusr#72 and uses some patches from nillerusr#193 for better portability between UNIXes. Also this patch replaces so many NULLs with 0 or '\0' because musl headers redefines it and anyway it is better practice. Moreover, due to very "cool" code from Valve, some modules comes with disabled fortify which distributes with build-base in Alpine (fortify is something like compile-time checking for memory bounds)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Test with hardware acceleration