Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor shouldRejectNodePromise method in AsyncTree class #4162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AbhisekOmkar
Copy link

This commit modifies the shouldRejectNodePromise method in the AsyncTree class to correctly access the properties of the node argument passed to the method, rather than relying on the this.currentNode property. Specifically, the isES6Async property is now accessed from the node parameter, ensuring accurate checks for ES6 async functions. This change improves the correctness and flexibility of promise rejection conditions in the AsyncTree class.

Affected method:

  • shouldRejectNodePromise(err, node = this.currentNode)

Changes:

  • Changed access to isES6Async property from this.currentNode to node.

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2024

CLA assistant check
All committers have signed the CLA.

@gravityvi
Copy link
Member

@AbhisekOmkar Thanks for the contribution. Can you point out the issue that you are trying to solve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants