Add tests of basic settings functionality

nickgaya · May 16, 2021 · 2d91e55 · 2d91e55
1 parent a9958fa
commit 2d91e55
Show file tree

Hide file tree

Showing 8 changed files with 209 additions and 47 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -3,6 +3,7 @@
 ## Version 1.3
 
 - Add per-domain settings for deduplicating by thumbnail
+- Automate basic browser tests using Selenium
 - Minor fixes/improvements
 
 ## Version 1.2

diff --git a/chrome.jq b/chrome.jq
@@ -26,3 +26,6 @@
     "48": "icons/icon48.png",
     "128": "icons/icon128.png"
 })
+
+# Chrome emits a spurious warning about browser_specific_settings
+| del(.browser_specific_settings)
diff --git a/manifest.json b/manifest.json
@@ -8,6 +8,12 @@
   "description": "Hide duplicate posts on pre-redesign Reddit.",
   "homepage_url": "https://nickgaya.github.io/rededup/",
 
+  "browser_specific_settings": {
+    "gecko": {
+      "id": "{68f0c654-5a3d-423b-b846-2b3ab68d05dd}"
+    }
+  },
+
   "icons": {
     "48": "icons/icon.svg",
     "96": "icons/icon.svg"

diff --git a/rededup.js b/rededup.js
@@ -195,7 +195,10 @@ async function getLinkInfo(thing, pageType, settings) {
                 if (settings.showHashValues) {
                     const hashElt = document.createElement('code');
                     hashElt.textContent = bufToHex(linkInfo.thumbnailHash);
-                    getTagline(thing, pageType).append(' [', hashElt, ']');
+                    const spanElt = document.createElement('span');
+                    spanElt.classList.add('rededup-hash');
+                    spanElt.append(' [', hashElt, ']');
+                    getTagline(thing, pageType).append(spanElt);
                 }
             } catch (error) {
                 console.warn("Failed to get thumbnail hash", thumbnailImg,

diff --git a/tests/README.md b/tests/README.md
@@ -5,7 +5,8 @@ gecko-webdriver to be installed on your system.
 
 To run the tests:
 
-    export REDEDUP_PATH=../artifacts/rededup-<version>-fx.zip npm test
+    export REDEDUP_PATH=../artifacts/rededup-<version>-fx.zip
+    npm test
 
 By default, the tests run in "headless" mode. To enable the browser GUI, you
 can set the environment variable `BROWSER_GUI=true`.
diff --git a/tests/package-lock.json b/tests/package-lock.json
diff --git a/tests/package.json b/tests/package.json
@@ -3,7 +3,8 @@
   "devDependencies": {
     "chai": "^4.3.4",
     "mocha": "^8.4.0",
-    "selenium-webdriver": "^4.0.0-beta.3"
+    "selenium-webdriver": "^4.0.0-beta.3",
+    "uuid": "^8.3.2"
   },
   "mocha": {
     "ui": "tdd"