FiltersDialog now uses a color picker for color selection #194
+216
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-FiltersDialog no long uses a drop down box of predefined SVG color strings. In place it uses two push buttons that launch a QColorDialog. This allows custom color specification. -refactored Filter class to QColor for its fore and back colors, instead of the old approach which uses strings. -incrememnted FilterSet::FILTERSET_VERSION to 2, since Filters noW store custom colors. These colors are saved in config as hex strings. BACKWARDS COMPATIBILITY IS MAINTAINED WITH VERSION 1 CONFIG FILES.
|
I believe the travis-ci clang build is broken, unrelated to this commit. |
|
Qt in brew has been updated to 5.10. Seems like this version does not support macos 10.7. Changing to 10.8 in glogg.pro should fix ci build. |
|
Should that be fixed in the mainline, then I pull in the commit to my fork, then resubmit pull request? Are pull requests ever accepted with failed continuous integration builds? |
|
I've created PR #202 to address ci issue |
|
Has this pull request not been accepted because the design direction is not desirable, or because the code implementation is not of a high enough quality? Or is it just a matter of free time to review it? I would be willing to address the issues, if there were some. |
variar
added a commit
to variar/klogg
that referenced
this pull request
Jan 30, 2019
danberindei
pushed a commit
to danberindei/glogg
that referenced
this pull request
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-FiltersDialog no longer uses a drop down box of predefined SVG color strings. In place it uses two push buttons that launch a QColorDialog. This allows for custom color specification.
-refactored Filter class to use QColor for its fore and back colors, instead of the old approach which uses strings. This reduces coupling with UI.
-incrememnted FilterSet::FILTERSET_VERSION to 2, since Filters now store custom colors. These colors are saved in config as hex strings. BACKWARDS COMPATIBILITY IS MAINTAINED WITH VERSION 1 CONFIG FILES. (made the assumption that backwards compatibility should always be maintained.)