Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate MarshalJSON, add IsZero methods #13

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Deprecate MarshalJSON, add IsZero methods #13

merged 4 commits into from
Feb 17, 2025

Conversation

jonathansharman
Copy link
Contributor

@jonathansharman jonathansharman commented Feb 12, 2025 •
edited
Loading

Dependencies

None.

Documentation

DELTA-1229: Update nullable docs with regard to omitzero

Description

  • Updates documentation to recommend using omitzero + json.Marshal for nup.Update and nup.SliceUpdate struct fields
  • Deprecates nup.MarshalJSON, which because of omitzero is no longer needed
  • Adds IsZero methods to nup.Update and nup.Update and nup.SliceUpdate. This was not strictly necessary since no-op updates were already zero-valued, but this makes it explicit.
  • Uses the expect package to simplify existing unit tests

Testing Considerations

Tested via unit tests and https://github.com/nicheinc/entity/pull/342.

Versioning

Minor - adds new symbols.

@jonathansharman jonathansharman marked this pull request as ready for review February 13, 2025 00:04
angelowilliams
angelowilliams approved these changes Feb 17, 2025
View reviewed changes
Copy link

@angelowilliams angelowilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonathansharman jonathansharman merged commit a1ff86e into main Feb 17, 2025
3 checks passed
@jonathansharman jonathansharman deleted the feature/omitzero branch February 17, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelowilliams angelowilliams angelowilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathansharman @angelowilliams