fix: remove auth headers passed to fetchUpload

nhost · May 9, 2024 · 22ecafe · 22ecafe
1 parent 87f1986
commit 22ecafe
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 11 deletions.
diff --git a/.changeset/spicy-trains-trade.md b/.changeset/spicy-trains-trade.md
@@ -1,7 +1,7 @@
 ---
-'@nhost/hasura-storage-js': patch
-'@nhost/graphql-js': patch
-'@nhost/nhost-js': patch
+'@nhost/hasura-storage-js': minor
+'@nhost/graphql-js': minor
+'@nhost/nhost-js': minor
 ---
 
 feat: add `setHeaders` method enabling global configuration of storage, graphql, and functions client headers, alongside added support for passing specific headers with individual calls
diff --git a/packages/graphql-js/src/client.ts b/packages/graphql-js/src/client.ts
@@ -236,7 +236,7 @@ export class NhostGraphqlClient {
  * @example
  * ```ts
  * nhost.graphql.setHeaders({
- * 'x-hasura-role'
+ * 'x-hasura-role': 'admin'
  * })
  * ```
  *

diff --git a/packages/hasura-storage-js/src/hasura-storage-api.ts b/packages/hasura-storage-js/src/hasura-storage-api.ts
@@ -44,7 +44,6 @@ export class HasuraStorageApi {
  const { error, fileMetadata } = await fetchUpload(this.url, formData, {
  bucketId,
  headers: {
- ...this.generateAuthHeaders(),
  ...this.headers, // global nhost storage client headers to be sent with all `uploadFormData` calls
  ...extraHeaders // extra headers to be sent with a specific call
  },
@@ -87,8 +86,8 @@ export class HasuraStorageApi {
  fileId: id,
  name,
  headers: {
- ...this.headers,
- ...extraHeaders // global nhost storage client headers to be sent with all `uploadFile` calls
+ ...this.headers, // global nhost storage client headers to be sent with all `uploadFile` calls
+ ...extraHeaders // extra headers to be sent with a specific call
  }
  })
 
@@ -120,7 +119,7 @@ export class HasuraStorageApi {
  headers: {
  ...this.generateAuthHeaders(),
  ...this.headers, // global nhost storage client headers to be sent with all `downloadFile` calls
- ...extraHeaders
+ ...extraHeaders // extra headers to be sent with a specific call
  }
  })
 
@@ -145,7 +144,7 @@ export class HasuraStorageApi {
  headers: {
  ...this.generateAuthHeaders(),
  ...this.headers, // global nhost storage client headers to be sent with all `getPresignedUrl` calls
- ...extraHeaders
+ ...extraHeaders // extra headers to be sent with a specific call
  }
  })
  if (!response.ok) {
@@ -166,7 +165,7 @@ export class HasuraStorageApi {
  headers: {
  ...this.generateAuthHeaders(),
  ...this.headers, // global nhost storage client headers to be sent with all `delete` calls
- ...extraHeaders
+ ...extraHeaders // extra headers to be sent with a specific call
  }
  })
  if (!response.ok) {

diff --git a/packages/hasura-storage-js/src/hasura-storage-client.ts b/packages/hasura-storage-js/src/hasura-storage-client.ts
@@ -236,7 +236,7 @@ export class HasuraStorageClient {
  * @example
  * ```ts
  * nhost.storage.setHeaders({
- * "x-hasura-role": "admin"
+ * 'x-hasura-role': 'admin'
  * })
  * ```
  *