Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gateway api -> endpoints #588

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Alice-Lilith
Copy link
Contributor

@Alice-Lilith Alice-Lilith commented Feb 11, 2025

Adds support for conversion from Gateway API into endpoints. Best reviewed one commit at a time since there are a ton of updates to the tests and test data (which is a bulk of the changed content)

I'll add support for reference grants in a follow-up after this. We already don't support them for the Gateway API Edges conversion and this PR is already quite large even minus the test data.

I updated our Gateway API version to pull in some of the newer features which also required an update to controller runtime that meant I had to go update some changed function signatures in a few other unrelated controllers to satisfy the new package requirements.

@github-actions github-actions bot added the area/controller Issues dealing with the controller label Feb 11, 2025
Signed-off-by: Alice-Lilith <[email protected]>
Signed-off-by: Alice-Lilith <[email protected]>
@Alice-Lilith Alice-Lilith marked this pull request as ready for review February 12, 2025 00:05
@Alice-Lilith Alice-Lilith requested a review from a team as a code owner February 12, 2025 00:05
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 72.55587% with 393 lines in your changes missing coverage. Please review.

Project coverage is 28.43%. Comparing base (2d22cf7) to head (47128c8).

Files with missing lines Patch % Lines
pkg/managerdriver/translate_gatewayapi.go 85.12% 89 Missing and 20 partials ⚠️
internal/ir/ir.go 28.97% 67 Missing and 9 partials ⚠️
pkg/managerdriver/translator.go 83.06% 47 Missing and 16 partials ⚠️
internal/controller/gateway/gateway_controller.go 0.00% 61 Missing ⚠️
pkg/managerdriver/translate_ingresses.go 54.34% 21 Missing ⚠️
internal/store/store.go 0.00% 18 Missing ⚠️
pkg/managerdriver/endpoints.go 0.00% 17 Missing ⚠️
internal/store/cachestores.go 14.28% 12 Missing ⚠️
internal/controller/agent/tunnel_controller.go 0.00% 4 Missing ⚠️
...ternal/controller/bindings/forwarder_controller.go 0.00% 4 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
+ Coverage   23.87%   28.43%   +4.56%     
==========================================
  Files          89       90       +1     
  Lines       12588    13859    +1271     
==========================================
+ Hits         3005     3941     +936     
- Misses       9393     9690     +297     
- Partials      190      228      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alice-Lilith Alice-Lilith force-pushed the alicewasko/gateway-endpoints branch from 138b925 to 47128c8 Compare February 12, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Issues dealing with the controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant