-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gateway api -> endpoints #588
Open
Alice-Lilith
wants to merge
10
commits into
main
Choose a base branch
from
alicewasko/gateway-endpoints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alice-Lilith <[email protected]>
Signed-off-by: Alice-Lilith <[email protected]>
Signed-off-by: Alice-Lilith <[email protected]>
Signed-off-by: Alice-Lilith <[email protected]>
Signed-off-by: Alice-Lilith <[email protected]>
Signed-off-by: Alice-Lilith <[email protected]>
Signed-off-by: Alice-Lilith <[email protected]>
Signed-off-by: Alice-Lilith <[email protected]>
Signed-off-by: Alice-Lilith <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
==========================================
+ Coverage 23.87% 28.43% +4.56%
==========================================
Files 89 90 +1
Lines 12588 13859 +1271
==========================================
+ Hits 3005 3941 +936
- Misses 9393 9690 +297
- Partials 190 228 +38 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alice-Lilith <[email protected]>
138b925
to
47128c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for conversion from Gateway API into endpoints. Best reviewed one commit at a time since there are a ton of updates to the tests and test data (which is a bulk of the changed content)
I'll add support for reference grants in a follow-up after this. We already don't support them for the Gateway API Edges conversion and this PR is already quite large even minus the test data.
I updated our Gateway API version to pull in some of the newer features which also required an update to controller runtime that meant I had to go update some changed function signatures in a few other unrelated controllers to satisfy the new package requirements.