Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(matchers): add toHaveExactTrimmedText matcher #588

Merged
merged 1 commit into from
Nov 20, 2022
Merged

feat(matchers): add toHaveExactTrimmedText matcher #588

merged 1 commit into from
Nov 20, 2022

Conversation

skorupka-k
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #568

What is the new behavior?

  • toHaveExactText matcher accepts a second parameter that allows to trim actual text value before being checked, e.g. expect(element).toHaveExactText('some text', true);
  • toHaveExactTrimmedText matcher is added as a convenient shorthand for the above

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@stackblitz
Copy link

stackblitz bot commented Oct 31, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

NetanelBasal
NetanelBasal reviewed Nov 1, 2022
View reviewed changes
projects/spectator/jest/src/lib/matchers-types.ts Outdated
@@ -18,7 +18,9 @@ declare namespace jest {

toContainText(text: string | string[] | ((text: string) => boolean), exact?: boolean): boolean;

toHaveExactText(text: string | string[] | ((text: string) => boolean)): boolean;
toHaveExactText(text: string | string[] | ((text: string) => boolean), trim?: boolean): boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change it to { trim: boolean }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@skorupka-k
Copy link
Contributor Author

@NetanelBasal any update here?

@NetanelBasal NetanelBasal merged commit bb5b843 into ngneat:master Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NetanelBasal NetanelBasal Awaiting requested review from NetanelBasal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skorupka-k @NetanelBasal