Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update widget.py: fix html icon display none #1072

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

wangm23456
Copy link
Contributor

Fix the problem that the icons does not display in html.

> python -c 'import nglview; print(nglview.__version__)'
3.0.6
> python -c 'import ipywidgets; print(ipywidgets.__version__)'
8.1.0

@hainm
Copy link
Collaborator

hainm commented Aug 29, 2023

@wangm23456 thanks for the fix. Can you please post the screenshot of the broken one?

@wangm23456
Copy link
Contributor Author

@wangm23456 thanks for the fix. Can you please post the screenshot of the broken one? 感谢您的修复。可以发一下损坏的截图吗?

image

I found some issues regarding this in jupyter-widgets, but I am unsure how to solve them using jupyter.

jupyter-widgets/ipywidgets#3658 (comment)
jupyter-widgets/ipywidgets#3623 (comment)
jupyter-widgets/ipywidgets#3000 (comment)

@hainm hainm merged commit 0e1cb52 into nglviewer:master Aug 31, 2023
1 of 3 checks passed
@hainm
Copy link
Collaborator

hainm commented Aug 31, 2023

Thanks @wangm23456 very much.

@hainm hainm mentioned this pull request Aug 31, 2023
@hainm
Copy link
Collaborator

hainm commented Aug 31, 2023

published pypi package:
image

will be available in conda soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants