-
Notifications
You must be signed in to change notification settings - Fork 345
rust: Update rust crates #1588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust: Update rust crates #1588
Conversation
ac000
commented
Apr 7, 2025
•
edited
Loading
edited
Update (cargo update) the rust crates for wasm-wasi-component, otel & unitctl. This will fix build issues with wasm-wasi-component & rustc 1.86+. It will also fix dependabot issues in otel and unitctl. Link: <bytecodealliance/wasmtime#10184> Link: <nginx#1585> Link: <nginx#1589> Link: <nginx#1570> Signed-off-by: Andrew Clayton <[email protected]>
|
Yeah, looks like we're hitting the exact issue on homebrew that has a newer Rust version: https://github.com/nginx/homebrew-unit/actions/runs/14298398297/job/40216705842 Also, this will make us depend on Rust 1.83+ afaict... |
Such is rust life... |
And now this is also failing... fsck... remind me again who said rust was a good idea?! @thresheek Feel free the approve this PR! |
Although this new failure is from building wasmtime from source... is it bundling an old version of the problematic crate? Either way, not sure why we're bothering to build it from source here... |
Seeing if bumping wasmtime to 31.0.0 in pkg/contrib fixes things... |
I think we need to bump wasmtime in both pkg/contrib and src/wasm-wasi-component/Cargo.toml stuff - since https://github.com/nginx/unit/actions/runs/14362591784/job/40267665156?pr=1591 fails the similar way That said, maybe other crates need a bump in Cargo.toml too. |
Indeed, building wasmtime 31.0.0 is warning and error free... |
This PR updates all crates in This PR bumps |
Note: The important bit to update was |
However, while this PR obviously fixes the wasm-wasi-component build, I'm not sure why the wasm test isn't failing with the wamtime build, which while having the compilation warnings doesn't have the compilation error that we are now seeing elsewhere... strange... anyway between this and the other PR it should be all good... |
I think the ubuntu-latest runners just had a software bump, which probably explains what we've been seeing: E.g. https://github.com/nginx/unit/actions/runs/14362591784/job/40267664555?pr=1591 was picked up by:
Which seems to have Rust 1.86.0 While https://github.com/nginx/unit/actions/runs/14335337085/job/40180839867?pr=1588 was picked up by an older version:
Which had Rust 1.85.1. |
Err, wrong first job URL, but I think that doesnt really matter much. |