Skip to content

feat: Add support for the NGINX ngx_mgmt_module module. #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025
Merged

Conversation

alessfg
Copy link
Member

@alessfg alessfg commented May 8, 2025

Proposed changes

Add templating support for the ngx_mgmt_module NGINX module.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

@Copilot Copilot AI review requested due to automatic review settings May 8, 2025 14:00
@alessfg alessfg requested a review from a team as a code owner May 8, 2025 14:00
@alessfg alessfg changed the title feat: Add support for NGINX ngx_mgmt_module module. feat: Add support for the NGINX ngx_mgmt_module module. May 8, 2025
@github-actions github-actions bot added the enhancement Enhance an existing feature label May 8, 2025
@alessfg alessfg self-assigned this May 8, 2025
@alessfg alessfg added this to the 0.7.2 milestone May 8, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces templating support for the NGINX ngx_mgmt_module, while updating the default configuration and Molecule tests to validate the new management directives.

  • Added a new mgmt block in the nginx.conf.j2 template that conditionally renders management configuration.
  • Expanded the core.j2 macros to include mgmt configuration logic.
  • Updated Molecule tests and default templates to support NGINX Plus configuration using the mgmt directives.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
templates/nginx.conf.j2 Inserts a conditional mgmt block to render management configuration.
templates/core.j2 Adds a macro for generating mgmt directives.
molecule/entitlement_plus/verify.yml Adds Molecule tests verifying NGINX Plus presence and service state.
molecule/entitlement_plus/prepare.yml Prepares license files; note potential inconsistency for JWT processing.
molecule/entitlement_plus/molecule.yml Adds a new job for entitlement_plus testing in the workflow.
molecule/entitlement_plus/converge.yml Configures NGINX including new mgmt parameters via ansible-role-nginx-config.
defaults/main/template.yml Provides default mgmt configuration values supporting NGINX Plus.
CHANGELOG.md Updates changelog to reflect support for both management and stream modules.
.github/workflows/molecule.yml Updates workflow to run entitlement_plus tests.

@alessfg alessfg enabled auto-merge May 8, 2025 18:17
@alessfg alessfg added this pull request to the merge queue May 9, 2025
Merged via the queue into main with commit 97d74a2 May 9, 2025
15 checks passed
@alessfg alessfg deleted the entitlement branch May 9, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants